Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2520)

Unified Diff: Source/platform/PopupMenuClient.h

Issue 736883002: Implement <select> Popup Menu using PagePopup (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/PopupMenuClient.h
diff --git a/Source/platform/PopupMenuClient.h b/Source/platform/PopupMenuClient.h
index 2e0d1c33765ee65452883b41a0b82c1055c375ae..06f0281ff4ecf4c3ec6318de6b17449b5b339715 100644
--- a/Source/platform/PopupMenuClient.h
+++ b/Source/platform/PopupMenuClient.h
@@ -29,6 +29,9 @@
namespace blink {
+class HTMLElement;
+class RenderStyle;
+
class PopupMenuClient {
public:
virtual ~PopupMenuClient() { }
@@ -51,6 +54,9 @@ public:
virtual bool itemIsLabel(unsigned listIndex) const = 0;
virtual bool itemIsSelected(unsigned listIndex) const = 0;
virtual void setTextFromItem(unsigned listIndex) = 0;
+ virtual IntRect elementRectRelativeToRootView() const = 0;
+ virtual Element& ownerElement() const = 0;
tkent 2014/12/15 02:10:52 Layering violation. platform/* can't depend on co
keishi 2014/12/15 08:29:42 Done.
+ virtual RenderStyle* renderStyleForItem(HTMLElement&) const = 0;
virtual void listBoxSelectItem(int /*listIndex*/, bool /*allowMultiplySelections*/, bool /*shift*/, bool /*fireOnChangeNow*/ = true) { ASSERT_NOT_REACHED(); }
virtual bool multiple() const

Powered by Google App Engine
This is Rietveld 408576698