Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 736793004: Repair/Enable TabCaptureApiTest.FullscreenEvents. (Closed)

Created:
6 years, 1 month ago by miu
Modified:
6 years, 1 month ago
Reviewers:
hubbe
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Repair/Enable TabCaptureApiTest.FullscreenEvents. This test was disabled long ago, before Fullscreen-Within-Tab was implemented. When attempting to re-enable, it became clear that toggling browser fullscreen directly via FullscreenController was not a workable approach. This change fixes the issue by instead sending simulated mouse click events to the renderer, with JS code in the renderer toggling fullscreen via the HTML5 Fullscreen JS API. BUG=367349 Committed: https://crrev.com/bd99c31abff6648dadaf101ddded95ff5002959e Cr-Commit-Position: refs/heads/master@{#305089}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -30 lines) Patch
M chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc View 1 4 chunks +25 lines, -25 lines 0 comments Download
M chrome/test/data/extensions/api_test/tab_capture/fullscreen_test.html View 1 chunk +19 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/tab_capture/fullscreen_test.js View 2 chunks +24 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
miu
hubbe: PTAL (this is the 2nd one).
6 years, 1 month ago (2014-11-19 22:33:25 UTC) #2
hubbe
lgtm
6 years, 1 month ago (2014-11-19 23:24:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/736793004/40001
6 years, 1 month ago (2014-11-20 21:25:54 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-20 22:26:02 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 22:26:38 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bd99c31abff6648dadaf101ddded95ff5002959e
Cr-Commit-Position: refs/heads/master@{#305089}

Powered by Google App Engine
This is Rietveld 408576698