cc: Implement geometry-based tile eviction

cc/resources/tiling_set_eviction_queue.h

Index: cc/resources/tiling_set_eviction_queue.h
diff --git a/cc/resources/tiling_set_eviction_queue.h b/cc/resources/tiling_set_eviction_queue.h
index f88ce3bd710b0c9c88d1426261741f807c15146d..432c8e9a035a8cb9e9cb1495ae45b463bda385ed 100644
--- a/cc/resources/tiling_set_eviction_queue.h
+++ b/cc/resources/tiling_set_eviction_queue.h
@@ -5,6 +5,8 @@
 #ifndef CC_RESOURCES_TILING_SET_EVICTION_QUEUE_H_
 #define CC_RESOURCES_TILING_SET_EVICTION_QUEUE_H_
 
+#include <vector>
+
 #include "cc/base/cc_export.h"
 #include "cc/resources/picture_layer_tiling_set.h"
 
@@ -14,7 +16,8 @@ class CC_EXPORT TilingSetEvictionQueue {
  public:
   TilingSetEvictionQueue();
   TilingSetEvictionQueue(PictureLayerTilingSet* tiling_set,
-                         TreePriority tree_priority);
+                         TreePriority tree_priority,
+                         bool skip_shared_out_of_order_tiles);
   ~TilingSetEvictionQueue();
 
   Tile* Top();
@@ -23,26 +26,37 @@ class CC_EXPORT TilingSetEvictionQueue {
   bool IsEmpty() const;
 
  private:
-  bool AdvanceToNextCategory();
   bool AdvanceToNextEvictionTile();
+  bool AdvanceToNextPriorityBin();
   bool AdvanceToNextTilingRangeType();
   bool AdvanceToNextValidTiling();
+  bool AdvanceToSkewport();
 
   PictureLayerTilingSet::TilingRange CurrentTilingRange() const;
   size_t CurrentTilingIndex() const;
+  bool IsSharedOutOfOrderTile(const Tile* tile) const;
+
+  void SetCurrentRequiredForActivationTilingIndex(size_t index);
 
   PictureLayerTilingSet* tiling_set_;
   TreePriority tree_priority_;
+  bool skip_shared_out_of_order_tiles_;
+  bool processing_required_for_activation_tiling_;

[vmpstr, 2014/12/09 02:10:59]

I'm not sure what this means.. tilings aren't typically classified as required
for activation, just tiles. Is this true if we're processing a pending tree high
res tiling?

[USE eero AT chromium.org, 2014/12/09 18:44:15]

Yes. But it is also true if we are processing the an active tree tiling whose
twin tiling is the high res pending tree tiling and we are returning shared
required-for-activation tiles from the active tree eviction queue because tree
priority is SMOOTHNESS_TAKES_PRIORITY.

Do you have a better name? Should it be
processing_tiling_having_required_for_activation_tiles_, or something? That does
not tell that it can be a twin tiling, though.

[vmpstr, 2014/12/09 19:47:55]

I see. I think the second name is better, since it kinda says that you'er
processing a tiling and that tiling might have tiles required for activation...
Maybe even something like processing_tiling_with_required_for_activation_tiles_

[USE eero AT chromium.org, 2014/12/10 12:35:45]

Done.

+  bool processing_soon_border_rect_;
 
-  PictureLayerTiling::EvictionCategory current_category_;
+  TilePriority::PriorityBin current_priority_bin_;
+  PictureLayerTiling* current_tiling_;
   size_t current_tiling_index_;
+  size_t current_required_for_activation_tiling_index_;
   PictureLayerTilingSet::TilingRangeType current_tiling_range_type_;
   Tile* current_eviction_tile_;
 
-  const std::vector<Tile*>* eviction_tiles_;
-  size_t next_eviction_tile_index_;
+  TilingData::ReverseSpiralDifferenceIterator spiral_iterator_;
+  TilingData::Iterator visible_iterator_;
+  std::vector<Tile*> unoccluded_now_tiles_;
+  size_t next_unoccluded_now_tile_index_;
 };
 
 }  // namespace cc
 
-#endif  // CC_RESOURCES_TILING_SET_RASTER_QUEUE_H_
+#endif  // CC_RESOURCES_TILING_SET_EVICTION_QUEUE_H_