Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1409)

Unified Diff: cc/resources/tiling_set_eviction_queue.h

Issue 736753002: cc: Implement geometry-based tile eviction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/resources/tiling_set_eviction_queue.h
diff --git a/cc/resources/tiling_set_eviction_queue.h b/cc/resources/tiling_set_eviction_queue.h
index f88ce3bd710b0c9c88d1426261741f807c15146d..4463cc39dbab835e2328f16a4a863a57b60f08db 100644
--- a/cc/resources/tiling_set_eviction_queue.h
+++ b/cc/resources/tiling_set_eviction_queue.h
@@ -5,16 +5,79 @@
#ifndef CC_RESOURCES_TILING_SET_EVICTION_QUEUE_H_
#define CC_RESOURCES_TILING_SET_EVICTION_QUEUE_H_
+#include <vector>
+
#include "cc/base/cc_export.h"
#include "cc/resources/picture_layer_tiling_set.h"
namespace cc {
+// This eviction queue returned tiles from all tilings in a tiling set in
vmpstr 2014/12/11 18:35:03 That's awesome. Thanks for the comment.
+// the following order:
+// 1) Eventually rect tiles (EVENTUALLY tiles).
+// 1) Eventually rect tiles not required for activation from each tiling in
+// the tiling set, in turn, in the following order:
+// 1) the first higher than high res tiling, the second one and so on
+// 2) the first lower than low res tiling, the second one and so on
+// 3) the first between high and low res tiling, the second one and so on
+// 4) low res tiling
+// 5) high res tiling
+// 2) Eventually rect tiles required for activation from the tiling with
+// required for activation tiles. In the case of a pending tree tiling
+// set that is the high res tiling. In the case of an active tree tiling
+// set that is a tiling whose twin tiling is a pending tree high res
+// tiling.
+// 2) Soon border rect and skewport rect tiles (whose priority bin is SOON
+// unless the max tile priority bin is lowered by PictureLayerTilingClient).
+// 1) Soon border rect and skewport rect tiles not required for activation
+// from each tiling in the tiling set.
+// * Tilings are iterated in the same order as in the case of eventually
+// rect tiles not required for activation.
+// * For each tiling, first soon border rect tiles and then skewport
+// rect tiles are returned.
+// 2) Soon border rect and skewport rect tiles required for activation from
+// the tiling with required for activation tiles.
+// * First soon border rect tiles and then skewport rect tiles are
+// returned.
+// 3) Visible rect tiles (whose priority bin is NOW unless the max tile
+// priority bin is lowered by PictureLayerTilingClient).
+// 1) Visible rect tiles not required for activation from each tiling in
+// the tiling set.
+// * Tilings are iterated in the same order as in the case of eventually
+// rect tiles not required for activation.
+// * For each tiling, first occluded tiles and then unoccluded tiles
+// are returned.
+// 2) Visible rect tiles required for activation from the tiling with
+// required for activation tiles.
+// * First occluded tiles and then unoccluded tiles are returned.
+// If the max tile priority bin is lowered by PictureLayerTilingClient,
+// occlusion is not taken into account as occlusion is meaningful only for
+// NOW tiles.
+//
+// Within each tiling and tile priority rect, tiles are returned in reverse
+// spiral order i.e. in (mostly) decreasing distance-to-visible order.
+//
+// If the skip_shared_out_of_order_tiles value passed to the constructor is
+// true (like it should be when there is a twin layer with a twin tiling set),
+// eviction queue does not return shared which are out of order because their
+// priority for tree priority is lowered or raised by a twin layer.
+// * If tree_priority is SAME_PRIORITY_FOR_BOTH_TREES, this happens for
+// a tile specific lower priority tree eviction queue (because priority for
+// tree priority is a merged priority).
+// * If tree priority is NEW_CONTENT_TAKES_PRIORITY, this happens for
+// an active tree eviction queue (because priority for tree priority is
+// the pending priority).
+// * If tree_priority is SMOOTHNESS_TAKES_PRIORITY, this happens for a pending
+// tree eviction queue (because priority for tree priority is the active
+// priority).
+// Those skipped shared out of order tiles are when returned only by the twin
+// eviction queue.
class CC_EXPORT TilingSetEvictionQueue {
public:
TilingSetEvictionQueue();
TilingSetEvictionQueue(PictureLayerTilingSet* tiling_set,
- TreePriority tree_priority);
+ TreePriority tree_priority,
+ bool skip_shared_out_of_order_tiles);
~TilingSetEvictionQueue();
Tile* Top();
@@ -23,26 +86,36 @@ class CC_EXPORT TilingSetEvictionQueue {
bool IsEmpty() const;
private:
- bool AdvanceToNextCategory();
bool AdvanceToNextEvictionTile();
+ bool AdvanceToNextPriorityBin();
bool AdvanceToNextTilingRangeType();
bool AdvanceToNextValidTiling();
PictureLayerTilingSet::TilingRange CurrentTilingRange() const;
size_t CurrentTilingIndex() const;
+ bool IsSharedOutOfOrderTile(const Tile* tile) const;
+ size_t TilingIndexWithRequiredForActivationTiles() const;
PictureLayerTilingSet* tiling_set_;
+ WhichTree tree_;
TreePriority tree_priority_;
+ bool skip_all_shared_tiles_;
+ bool skip_shared_out_of_order_tiles_;
+ bool processing_soon_border_rect_;
+ bool processing_tiling_with_required_for_activation_tiles_;
+ size_t tiling_index_with_required_for_activation_tiles_;
- PictureLayerTiling::EvictionCategory current_category_;
+ TilePriority::PriorityBin current_priority_bin_;
+ PictureLayerTiling* current_tiling_;
size_t current_tiling_index_;
PictureLayerTilingSet::TilingRangeType current_tiling_range_type_;
Tile* current_eviction_tile_;
- const std::vector<Tile*>* eviction_tiles_;
- size_t next_eviction_tile_index_;
+ TilingData::ReverseSpiralDifferenceIterator spiral_iterator_;
+ TilingData::Iterator visible_iterator_;
+ std::vector<Tile*> unoccluded_now_tiles_;
};
} // namespace cc
-#endif // CC_RESOURCES_TILING_SET_RASTER_QUEUE_H_
+#endif // CC_RESOURCES_TILING_SET_EVICTION_QUEUE_H_

Powered by Google App Engine
This is Rietveld 408576698