Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 736743003: Use content::Referrer to pass around referrers in the plugin code (Closed)

Created:
6 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
6 years, 1 month ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use content::Referrer to pass around referrers in the plugin code BUG=434628 R=bauerb@chromium.org,mkwst@chromium.org Committed: https://crrev.com/f71428e2754483bed8b8959cab09a359ce18d8e4 Cr-Commit-Position: refs/heads/master@{#304791}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -42 lines) Patch
M content/child/npapi/plugin_url_fetcher.h View 4 chunks +4 lines, -3 lines 0 comments Download
M content/child/npapi/plugin_url_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/webplugin_delegate.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/child/npapi/webplugin_delegate_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/webplugin_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/plugin_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/request_info.h View 1 2 chunks +3 lines, -6 lines 0 comments Download
M content/child/request_info.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/child/resource_dispatcher.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M content/child/resource_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/web_url_loader_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/plugin/webplugin_delegate_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/npapi/webplugin_impl.h View 5 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/npapi/webplugin_impl.cc View 6 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jochen (gone - plz use gerrit)
6 years, 1 month ago (2014-11-19 08:45:57 UTC) #1
Bernhard Bauer
lgtm
6 years, 1 month ago (2014-11-19 08:53:19 UTC) #2
Mike West
IPC (and the rest) LGTM % a tiny nit. https://codereview.chromium.org/736743003/diff/1/content/child/request_info.h File content/child/request_info.h (right): https://codereview.chromium.org/736743003/diff/1/content/child/request_info.h#newcode40 content/child/request_info.h:40: ...
6 years, 1 month ago (2014-11-19 08:54:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/736743003/20001
6 years, 1 month ago (2014-11-19 09:00:51 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-19 09:51:13 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 09:51:51 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f71428e2754483bed8b8959cab09a359ce18d8e4
Cr-Commit-Position: refs/heads/master@{#304791}

Powered by Google App Engine
This is Rietveld 408576698