Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1258)

Issue 73673002: Set focused TextInputMode to InputMethodEndingeIBus. (Closed)

Created:
7 years, 1 month ago by yoichio
Modified:
7 years ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Set focused TextInputMode to InputMethodEndingeIBus. This doesn't change actual behavior. BUG=244688 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237527

Patch Set 1 : rebase #

Total comments: 3

Patch Set 2 : Add InputContext #

Patch Set 3 : modify #

Total comments: 6

Patch Set 4 : modify #

Total comments: 4

Patch Set 5 : add comments #

Patch Set 6 : round comment #

Patch Set 7 : round comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -36 lines) Patch
M chrome/browser/chromeos/input_method/input_method_engine_ibus.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_ibus.cc View 1 2 3 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_ibus_browserttests.cc View 1 2 3 3 chunks +25 lines, -9 lines 0 comments Download
M ui/base/ime/chromeos/ibus_bridge.h View 1 2 3 4 5 2 chunks +19 lines, -1 line 0 comments Download
M ui/base/ime/chromeos/mock_ime_engine_handler.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M ui/base/ime/chromeos/mock_ime_engine_handler.cc View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M ui/base/ime/input_method_ibus.cc View 1 2 3 4 1 chunk +9 lines, -8 lines 0 comments Download
M ui/base/ime/input_method_ibus_unittest.cc View 1 2 3 4 5 chunks +19 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
yoichio
Could you review?
7 years, 1 month ago (2013-11-20 05:45:06 UTC) #1
Seigo Nonaka
nit: /TextInputMope/InputMethodMode/? lgtm, but please also add komatsu@ as the current owner.
7 years, 1 month ago (2013-11-20 05:47:14 UTC) #2
yoichio
Add komatsu@ as OWNER.
7 years, 1 month ago (2013-11-20 05:57:21 UTC) #3
yoichio
TextInputMope/Mode This patch is just the value passing so it is straightforward to write the ...
7 years, 1 month ago (2013-11-20 06:11:22 UTC) #4
Hiro Komatsu
https://codereview.chromium.org/73673002/diff/150001/chrome/browser/chromeos/input_method/input_method_engine_ibus.h File chrome/browser/chromeos/input_method/input_method_engine_ibus.h (right): https://codereview.chromium.org/73673002/diff/150001/chrome/browser/chromeos/input_method/input_method_engine_ibus.h#newcode81 chrome/browser/chromeos/input_method/input_method_engine_ibus.h:81: ibus::TextInputMode text_input_mode) OVERRIDE; How about making a struct like ...
7 years, 1 month ago (2013-11-20 06:51:02 UTC) #5
yoichio
https://codereview.chromium.org/73673002/diff/150001/chrome/browser/chromeos/input_method/input_method_engine_ibus.h File chrome/browser/chromeos/input_method/input_method_engine_ibus.h (right): https://codereview.chromium.org/73673002/diff/150001/chrome/browser/chromeos/input_method/input_method_engine_ibus.h#newcode81 chrome/browser/chromeos/input_method/input_method_engine_ibus.h:81: ibus::TextInputMode text_input_mode) OVERRIDE; On 2013/11/20 06:51:03, Hiro Komatsu wrote: ...
7 years ago (2013-11-25 08:45:10 UTC) #6
Hiro Komatsu
https://codereview.chromium.org/73673002/diff/570001/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc File chrome/browser/chromeos/input_method/input_method_engine_ibus.cc (right): https://codereview.chromium.org/73673002/diff/570001/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc#newcode442 chrome/browser/chromeos/input_method/input_method_engine_ibus.cc:442: IBusEngineHandlerInterface::InputContext context; You can make a constructor if you ...
7 years ago (2013-11-25 09:02:15 UTC) #7
yoichio
https://codereview.chromium.org/73673002/diff/570001/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc File chrome/browser/chromeos/input_method/input_method_engine_ibus.cc (right): https://codereview.chromium.org/73673002/diff/570001/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc#newcode442 chrome/browser/chromeos/input_method/input_method_engine_ibus.cc:442: IBusEngineHandlerInterface::InputContext context; On 2013/11/25 09:02:15, Hiro Komatsu wrote: > ...
7 years ago (2013-11-26 09:23:46 UTC) #8
Hiro Komatsu
https://codereview.chromium.org/73673002/diff/770001/ui/base/ime/chromeos/ibus_bridge.h File ui/base/ime/chromeos/ibus_bridge.h (right): https://codereview.chromium.org/73673002/diff/770001/ui/base/ime/chromeos/ibus_bridge.h#newcode71 ui/base/ime/chromeos/ibus_bridge.h:71: ui::TextInputType type; Please add comments about type and mode ...
7 years ago (2013-11-26 12:54:27 UTC) #9
yoichio
https://codereview.chromium.org/73673002/diff/770001/ui/base/ime/chromeos/ibus_bridge.h File ui/base/ime/chromeos/ibus_bridge.h (right): https://codereview.chromium.org/73673002/diff/770001/ui/base/ime/chromeos/ibus_bridge.h#newcode71 ui/base/ime/chromeos/ibus_bridge.h:71: ui::TextInputType type; On 2013/11/26 12:54:28, Hiro Komatsu wrote: > ...
7 years ago (2013-11-27 02:03:17 UTC) #10
Hiro Komatsu
lgtm
7 years ago (2013-11-27 02:08:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/73673002/790001
7 years ago (2013-11-27 03:22:07 UTC) #12
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=38300
7 years ago (2013-11-27 03:36:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/73673002/830001
7 years ago (2013-11-27 04:04:31 UTC) #14
commit-bot: I haz the power
7 years ago (2013-11-27 06:00:47 UTC) #15
Message was sent while issue was closed.
Change committed as 237527

Powered by Google App Engine
This is Rietveld 408576698