chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc - Issue 736663002: Refoctoring FileSelection and FileSelectionHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc

Issue 736663002: Refoctoring FileSelection and FileSelectionHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc

diff --git a/chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc b/chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc

index 40c51672a98fd9eda43a7c92a9a37cb0e53c63fc..81a7b7f64d7ffc2c6c00cb476ceeff06c98fa508 100644

--- a/chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc

+++ b/chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc

@@ -279,7 +279,7 @@ IN_PROC_BROWSER_TEST_F(SelectFileDialogExtensionBrowserTest,

// waiting for chrome.test.sendMessage('selection-change-complete').

ASSERT_NO_FATAL_FAILURE(OpenDialog(ui::SelectFileDialog::SELECT_OPEN_FILE,

test_file, owning_window,

- "selection-change-complete"));

+ "dialog-ready"));

// Click open button.

CloseDialog(DIALOG_BTN_OK, owning_window);

@@ -305,7 +305,7 @@ IN_PROC_BROWSER_TEST_F(SelectFileDialogExtensionBrowserTest,

// chrome.test.sendMessage().

ASSERT_NO_FATAL_FAILURE(OpenDialog(ui::SelectFileDialog::SELECT_SAVEAS_FILE,

test_file, owning_window,

- "directory-change-complete"));

+ "dialog-ready"));

// Click save button.

CloseDialog(DIALOG_BTN_OK, owning_window);

« no previous file with comments | « no previous file | ui/file_manager/file_manager/foreground/js/dialog_action_controller.js » ('j') | no next file with comments »