Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 736643002: Revert of [Extensions Toolbar] Properly render newly-added extensions (Closed)

Created:
6 years, 1 month ago by Michael Achenbach
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [Extensions Toolbar] Properly render newly-added extensions (patchset #1 id:1 of https://codereview.chromium.org/732203002/) Reason for revert: [Sheriff] Makes ExtensionActionContextMenuControllerTest.BrowserAction flaky on Mac and Mac dbg: Starting here: http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/681 http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/207 Original issue's description: > [Extensions Toolbar] Properly render newly-added extensions > > Fix a regression where newly-added extensions were not properly drawn. > Also have the newly-installed extension button stop tracking, so it doesn't try > to set state when the popup closes. > > BUG=433817 > > Committed: https://crrev.com/ebcd353dbbfff82230807a5d81dd8cd1b9b8441e > Cr-Commit-Position: refs/heads/master@{#304503} TBR=avi@chromium.org,rsesek@chromium.org,rdevlin.cronin@chromium.org NOTREECHECKS=true NOTRY=true BUG=433817 Committed: https://crrev.com/c4ed7d8c09e3d3b24289f69d985f51b802e4267f Cr-Commit-Position: refs/heads/master@{#304578}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Achenbach
Created Revert of [Extensions Toolbar] Properly render newly-added extensions
6 years, 1 month ago (2014-11-18 08:29:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/736643002/1
6 years, 1 month ago (2014-11-18 08:30:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-18 08:31:05 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c4ed7d8c09e3d3b24289f69d985f51b802e4267f Cr-Commit-Position: refs/heads/master@{#304578}
6 years, 1 month ago (2014-11-18 08:31:44 UTC) #4
Avi (use Gerrit)
6 years, 1 month ago (2014-11-18 16:18:05 UTC) #5
Message was sent while issue was closed.
On 2014/11/18 08:31:44, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/c4ed7d8c09e3d3b24289f69d985f51b802e4267f
> Cr-Commit-Position: refs/heads/master@{#304578}

Oh well. LGTM

Powered by Google App Engine
This is Rietveld 408576698