Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 736623002: [x64] Recognize MOVSXWL. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer
Modified:
6 years, 1 month ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[x64] Recognize MOVSXWL. Also add some debug code to verify correct zero extension of 32-bit moves. TEST=mjsunit/asm R=svenpanne@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/3c79e2e920ccf49dc5841a0b4ce3323f11d24ec0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M src/compiler/x64/code-generator-x64.cc View 4 chunks +12 lines, -1 line 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Sven Panne
lgtm
6 years, 1 month ago (2014-11-18 07:50:01 UTC) #2
Benedikt Meurer
6 years, 1 month ago (2014-11-18 07:52:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3c79e2e920ccf49dc5841a0b4ce3323f11d24ec0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698