chrome/browser/first_run/try_chrome_dialog_view.cc - Issue 736613002: Makes Separator more configurable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/first_run/try_chrome_dialog_view.cc

Issue 736613002: Makes Separator more configurable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: SetPrefferedize and then SetSize of separator Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/first_run/try_chrome_dialog_view.cc

diff --git a/chrome/browser/first_run/try_chrome_dialog_view.cc b/chrome/browser/first_run/try_chrome_dialog_view.cc

index d9d95b567981a09b47096e4cfddaea000eb2506d..767d31e6e4ee1cb0fc54e27f79d599f6ff7c1335 100644

--- a/chrome/browser/first_run/try_chrome_dialog_view.cc

+++ b/chrome/browser/first_run/try_chrome_dialog_view.cc

@@ -269,8 +269,8 @@ TryChromeDialogView::Result TryChromeDialogView::ShowModal(

layout->Layout(root_view);

gfx::Size preferred = layout->GetPreferredSize(root_view);

if (separator) {

- int separator_height = separator->GetPreferredSize().height();

- separator->SetSize(gfx::Size(preferred.width(), separator_height));

sky 2014/11/19 20:30:19 You shouldn't change this code. Leave it as is.

+ separator->SetPreferredSize(preferred.width());

+ separator->SetSize(separator->GetPreferredSize());

}

gfx::Rect pos = ComputeWindowPosition(preferred.width(), preferred.height(),

« no previous file with comments | « no previous file | ui/views/controls/separator.h » ('j') | ui/views/controls/separator.h » ('J')