Makes Separator more configurable.

ui/views/controls/separator.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_SEPARATOR_H_
 #define UI_VIEWS_CONTROLS_SEPARATOR_H_
 
 #include <string>
 
 #include "ui/views/view.h"
 
 namespace views {
 
 // The Separator class is a view that shows a line used to visually separate
 // other views.
 
 class VIEWS_EXPORT Separator : public View {
  public:
   enum Orientation {
     HORIZONTAL,
     VERTICAL
   };
 
   // The separator's class name.
   static const char kViewClassName[];
 
   explicit Separator(Orientation orientation);
+  Separator(Orientation orientation, SkColor color);

[sky, 2014/11/18 18:04:06]

We generally don't have constructors like this. At one point the style guide
frowned upon this, not sure that it does anymore.

Don't add any new constructors, instead add setters for the color and height.
Also, it shouldn't be called height but rather size.

[melandory, 2014/11/18 19:12:47]

Done.

+  Separator(Orientation orientation, SkColor color, int height);
+
   ~Separator() override;
 
   // Overridden from View:
   gfx::Size GetPreferredSize() const override;
   void GetAccessibleState(ui::AXViewState* state) override;
   void Paint(gfx::Canvas* canvas, const views::CullSet& cull_set) override;
   const char* GetClassName() const override;
 
  private:
   const Orientation orientation_;
+  const SkColor color_;
+  const int height_;
 
   DISALLOW_COPY_AND_ASSIGN(Separator);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_SEPARATOR_H_