Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 736583007: Enable "strict mode"; for debugger scripts (Closed)

Created:
6 years, 1 month ago by yurys
Modified:
6 years, 1 month ago
Reviewers:
aandrey, Yang, eseidel
CC:
v8-dev, eseidel, aandrey
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Enable "strict mode"; for debugger scripts BUG=v8:3708 Committed: https://chromium.googlesource.com/v8/v8/+/f39fbb7d26f3552e0f32aa3a29029cd72b58e7c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M src/debug-debugger.js View 3 chunks +3 lines, -2 lines 0 comments Download
M src/mirror-debugger.js View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
yurys
6 years, 1 month ago (2014-11-19 12:56:43 UTC) #2
Yang
On 2014/11/19 12:56:43, yurys wrote: lgtm!
6 years, 1 month ago (2014-11-19 12:57:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/736583007/1
6 years, 1 month ago (2014-11-19 13:02:59 UTC) #5
aandrey
lgtm
6 years, 1 month ago (2014-11-19 13:17:52 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-19 13:29:51 UTC) #8
eseidel
6 years, 1 month ago (2014-11-19 16:42:39 UTC) #10
Message was sent while issue was closed.
We also had to remove a couple uses of "const", but maybe that was in
DEbuggerScript.js and not debug-script.js

Powered by Google App Engine
This is Rietveld 408576698