Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Issue 736573002: Add unit tests for functions in math_utils.py (Closed)

Created:
6 years, 1 month ago by qyearsley
Modified:
6 years, 1 month ago
Reviewers:
RobertoCN, prasadv
CC:
chromium-reviews, Sergiy Byelozyorov
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add unit tests for functions in math_utils.py Specifically, this adds tests for: TruncatedMean Variance StandardDeviation StandardError which were not covered before. I also added a couple notes about things we may want to change in the behavior of the math_utils functions. Still not covered is PooledStandardError, unit test coverage can be added for that function in separate CL. BUG= Committed: https://crrev.com/bfa797e046fc92508cc5aad6b2fba7547ae33246 Cr-Commit-Position: refs/heads/master@{#305052}

Patch Set 1 #

Patch Set 2 : Updated an incorrect comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -36 lines) Patch
M tools/auto_bisect/math_utils.py View 4 chunks +15 lines, -8 lines 0 comments Download
M tools/auto_bisect/math_utils_test.py View 1 1 chunk +81 lines, -28 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
qyearsley
6 years, 1 month ago (2014-11-17 23:16:35 UTC) #2
qyearsley
On 2014/11/17 23:16:35, qyearsley wrote: PTAL
6 years, 1 month ago (2014-11-20 16:57:49 UTC) #4
prasadv
lgtm
6 years, 1 month ago (2014-11-20 17:52:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/736573002/20001
6 years, 1 month ago (2014-11-20 18:17:44 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-20 18:58:48 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 19:00:25 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bfa797e046fc92508cc5aad6b2fba7547ae33246
Cr-Commit-Position: refs/heads/master@{#305052}

Powered by Google App Engine
This is Rietveld 408576698