Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 736493007: MachMessageServer: don’t deal with MACH_SEND_TRAILER (Closed)

Created:
6 years ago by Mark Mentovai
Modified:
6 years ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

MachMessageServer: don’t deal with MACH_SEND_TRAILER. As documented, MACH_SEND_TRAILER would allow a sender to provide its own message trailer instead of having the kernel append its own kernel-generated trailer. This is a Mach feature that supports a network of multiple Mach hosts, but even in that environment, the option is restricted to use by privileged callers. In reality, MACH_SEND_TRAILER has never been implemented in OS X. The system’s mach_msg_server() family does consider the value of MACH_SEND_TRAILER, but this is pointless. Any purported trailer set by a server function would be ignored. Maintaining this code gives the illusion that it’s functional, so it’s being removed. TEST=util_test MachMessageServer.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/306625dac4df93af8ef014986fd5c34bdcc14d42

Patch Set 1 #

Patch Set 2 : Add comment #

Patch Set 3 : " #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M util/mach/mach_message_server.cc View 1 2 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Mark Mentovai
6 years ago (2014-11-24 23:12:06 UTC) #2
Robert Sesek
LGTM. Where'd you find that this was supposed to be fore networked Mach hosts?
6 years ago (2014-11-25 19:32:42 UTC) #3
Mark Mentovai
This breadcrumb in https://opensource.apple.com/source/xnu/xnu-2422.115.4/osfmk/man/mach_msg.html: > If set, the kernel, instead of determining the message attributes ...
6 years ago (2014-11-25 19:59:33 UTC) #4
Mark Mentovai
6 years ago (2014-11-25 20:00:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
306625dac4df93af8ef014986fd5c34bdcc14d42 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698