Web Animations: Extract an API for servicing animations

Source/core/animation/ActiveAnimations.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 28 matching lines @@
 bool shouldCompositeForActiveAnimations(const RenderObject& renderer, bool renderViewInCompositingMode)
 {
     ASSERT(RuntimeEnabledFeatures::webAnimationsCSSEnabled());
 
     if (!renderer.node() || !renderer.node()->isElementNode())
         return false;
 
     const Element* element = toElement(renderer.node());
     if (const ActiveAnimations* activeAnimations = element->activeAnimations()) {
         // FIXME: remove compositing mode check once compositing is forced on all platforms
-        bool shouldCompositeForActiveAnimation = (activeAnimations->hasActiveAnimations(CSSPropertyOpacity) && renderViewInCompositingMode)
+        if ((renderViewInCompositingMode && activeAnimations->hasActiveAnimations(CSSPropertyOpacity))
             || activeAnimations->hasActiveAnimations(CSSPropertyWebkitTransform)
-            || activeAnimations->hasActiveAnimations(CSSPropertyWebkitFilter);
-        return shouldCompositeForActiveAnimation || activeAnimations->cssAnimations().shouldCompositeForPendingAnimations(renderViewInCompositingMode);

[Steve Block, 2013/11/20 00:36:16]

I don't understand why we no longer check whether the pending animations should
be composited?

[dstockwell, 2013/11/20 00:49:16]

The animations in CSSPendingAnimations are now active but frozen at time 0, they
just don't have a start time.

+            || activeAnimations->hasActiveAnimations(CSSPropertyWebkitFilter))
+            return true;
     }
 
     return false;
 }
 
 bool hasActiveAnimations(const RenderObject& renderer, CSSPropertyID property)
 {
     ASSERT(RuntimeEnabledFeatures::webAnimationsCSSEnabled());
 
     if (!renderer.node() || !renderer.node()->isElementNode())
@@ skipping 30 matching lines @@
     return m_defaultStack.hasActiveAnimationsOnCompositor(property);
 }
 
 void ActiveAnimations::cancelAnimationOnCompositor()
 {
     for (PlayerSet::iterator it = m_players.begin(); it != players().end(); ++it)
         it->key->cancelAnimationOnCompositor();
 }
 
 } // namespace WebCore