Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 73643003: Web Animations CSS: Check if animating element exists before calculating animation update (Closed)

Created:
7 years, 1 month ago by Steve Block
Modified:
7 years, 1 month ago
Reviewers:
Timothy Loh
CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears
Visibility:
Public.

Description

Web Animations CSS: Check if animating element exists before calculating animation update This was introduced in r161985 and causes LayoutTests to crash when Web Animations is enabled. See https://codereview.chromium.org/71083002 R=timloh@chromium.org BUG=232273, 314952, 319646 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162164

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Steve Block
7 years, 1 month ago (2013-11-17 03:54:17 UTC) #1
Timothy Loh
lgtm Sorry I missed this in my patch.
7 years, 1 month ago (2013-11-17 04:42:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/73643003/1
7 years, 1 month ago (2013-11-17 04:42:31 UTC) #3
Timothy Loh
Does this fix crbug.com/320042? Given our timeline re-enabling the tests won't be too useful, but ...
7 years, 1 month ago (2013-11-17 05:06:05 UTC) #4
Steve Block
> Does this fix crbug.com/320042? Looking at the stack trace there, I imagine it would. ...
7 years, 1 month ago (2013-11-17 05:08:26 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 1 month ago (2013-11-17 06:20:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/73643003/1
7 years, 1 month ago (2013-11-17 06:21:57 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-17 06:22:35 UTC) #8
Message was sent while issue was closed.
Change committed as 162164

Powered by Google App Engine
This is Rietveld 408576698