components/devtools_bridge/android/session_dependency_factory_android.h - Issue 736363002: Stub for web-base client for DevTools bridge and tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/devtools_bridge/android/session_dependency_factory_android.h

Issue 736363002: Stub for web-base client for DevTools bridge and tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed presubmits Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/devtools_bridge/android/client/javatests/src/org/chromium/components/devtools_bridge/browsertests/TestApplication.java ('k') | components/devtools_bridge/android/session_dependency_factory_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/devtools_bridge/android/session_dependency_factory_android.h

diff --git a/components/devtools_bridge/android/session_dependency_factory_android.h b/components/devtools_bridge/android/session_dependency_factory_android.h

index 62ecae3222b6809065cd618c6c017b98701d9b1d..bfc8264d49ad04ff9d7847a6ac1504d838df0774 100644

--- a/components/devtools_bridge/android/session_dependency_factory_android.h

+++ b/components/devtools_bridge/android/session_dependency_factory_android.h

@@ -5,8 +5,9 @@

#ifndef COMPONENTS_DEVTOOLS_BRIDGE_ANDROID_SESSION_DEPENDENCY_FACTORY_ANDROID_H_

#define COMPONENTS_DEVTOOLS_BRIDGE_ANDROID_SESSION_DEPENDENCY_FACTORY_ANDROID_H_

+#include <jni.h>

#include "components/devtools_bridge/session_dependency_factory.h"

-#include "jni.h"

namespace devtools_bridge {

namespace android {

@@ -16,7 +17,7 @@ class SessionDependencyFactoryAndroid : public SessionDependencyFactory {

SessionDependencyFactoryAndroid();

virtual ~SessionDependencyFactoryAndroid();

- static void RegisterNatives(JNIEnv* env);

+ static bool RegisterNatives(JNIEnv* env);

virtual scoped_ptr<AbstractPeerConnection> CreatePeerConnection(

scoped_ptr<RTCConfiguration> config,