Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 73633002: Add more test cases for HttpUtil::PathForRequest() and SpecForRequest() (Closed)

Created:
7 years, 1 month ago by tyoshino (SeeGerritForStatus)
Modified:
7 years ago
Reviewers:
Adam Rice, szym
CC:
chromium-reviews, cbentzel+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Add more test cases for HttpUtil::PathForRequest() and SpecForRequest() https://codereview.chromium.org/68213017/ made them able to handle WebSocket schemes. Add tests to check that. Bonus: some more non-WebSocket cases to increase coverage. BUG=303568 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237941

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed #3 #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M net/http/http_util_unittest.cc View 1 2 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tyoshino (SeeGerritForStatus)
7 years, 1 month ago (2013-11-15 04:16:24 UTC) #1
tyoshino (SeeGerritForStatus)
Please ignore http_util_icu.cc change. I'll resolve it after your change is committed.
7 years, 1 month ago (2013-11-15 04:19:53 UTC) #2
Adam Rice
https://codereview.chromium.org/73633002/diff/1/net/http/http_util_unittest.cc File net/http/http_util_unittest.cc (right): https://codereview.chromium.org/73633002/diff/1/net/http/http_util_unittest.cc#newcode641 net/http/http_util_unittest.cc:641: // ftp scheme I would prefer to have this ...
7 years, 1 month ago (2013-11-15 08:01:44 UTC) #3
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/73633002/diff/1/net/http/http_util_unittest.cc File net/http/http_util_unittest.cc (right): https://codereview.chromium.org/73633002/diff/1/net/http/http_util_unittest.cc#newcode641 net/http/http_util_unittest.cc:641: // ftp scheme On 2013/11/15 08:01:44, Adam Rice wrote: ...
7 years, 1 month ago (2013-11-15 13:35:49 UTC) #4
Adam Rice
lgtm
7 years, 1 month ago (2013-11-18 06:43:42 UTC) #5
tyoshino (SeeGerritForStatus)
+szym
7 years ago (2013-11-29 04:42:17 UTC) #6
szym
7 years ago (2013-11-29 11:08:23 UTC) #7
szym
lgtm
7 years ago (2013-11-29 11:08:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/73633002/150001
7 years ago (2013-11-29 17:39:10 UTC) #9
commit-bot: I haz the power
7 years ago (2013-11-29 19:59:32 UTC) #10
Message was sent while issue was closed.
Change committed as 237941

Powered by Google App Engine
This is Rietveld 408576698