Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 736233004: Referrer Policy: Introduce "Origin When Cross-Origin". [1/3] (Closed)

Created:
6 years, 1 month ago by Mike West
Modified:
6 years, 1 month ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, mkwst+watchlist-csp_chromium.org, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Referrer Policy: Introduce "Origin When Cross-Origin". [1/3] As specified at [1], this patch adds the initial Blink-side of the new referrer policy. The Chromium side is mostly being taken care of in [2]. Tests will come once the Chromium side supports the new enum value and doesn't clear the header on redirect. [1/3]: This patch. [2/3]: Chromium - https://codereview.chromium.org/747043002/ [3/3]: Blink - https://codereview.chromium.org/747903003 [1]: https://w3c.github.io/webappsec/specs/referrer-policy/#origin-when-cross-origin [2]: https://codereview.chromium.org/714813003/ BUG=309551 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185807

Patch Set 1 #

Patch Set 2 : Feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -3 lines) Patch
M Source/core/dom/Document.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/csp/CSPDirectiveList.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/platform/weborigin/ReferrerPolicy.h View 1 chunk +7 lines, -2 lines 0 comments Download
M Source/platform/weborigin/SecurityPolicy.cpp View 2 chunks +12 lines, -0 lines 0 comments Download
M Source/platform/weborigin/SecurityPolicyTest.cpp View 1 1 chunk +84 lines, -0 lines 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M public/platform/WebReferrerPolicy.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Mike West
WDYT, Jochen? I need to wire it up to the right referrer policy on the ...
6 years, 1 month ago (2014-11-21 14:31:28 UTC) #2
jochen (gone - plz use gerrit)
would it make sense to add a unit test for the SecurityPolicy change?
6 years, 1 month ago (2014-11-21 14:34:05 UTC) #3
Mike West
Almost certainly! I'll run this by you again once I finish poking at browser_tests for ...
6 years, 1 month ago (2014-11-21 14:35:58 UTC) #4
Mike West
Added a test. Mind taking another look?
6 years, 1 month ago (2014-11-21 15:17:41 UTC) #5
jochen (gone - plz use gerrit)
lgtm
6 years, 1 month ago (2014-11-21 16:25:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/736233004/20001
6 years, 1 month ago (2014-11-21 16:29:20 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 17:23:06 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185807

Powered by Google App Engine
This is Rietveld 408576698