Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 736233003: Renaming "incoming_feedback_ssrc" to "receiver_ssrc" (Closed)

Created:
6 years, 1 month ago by anujsharma
Modified:
6 years, 1 month ago
Reviewers:
xhwang, miu
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org, MRV
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

TODO(miu): Rename to receiver_ssrc BUG= Committed: https://crrev.com/69ac8f09df487a1cab533e888632c2d8adc16cbb Cr-Commit-Position: refs/heads/master@{#305174}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -24 lines) Patch
M chrome/renderer/media/cast_rtp_stream.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/cast/cast_config.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/cast_config.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/sender/audio_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/external_video_encoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/video_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/video_sender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/test/cast_benchmarks.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M media/cast/test/end2end_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M media/cast/test/sender.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/test/utility/default_config.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
anujsharma
PTAL
6 years, 1 month ago (2014-11-20 13:28:33 UTC) #2
miu
lgtm xhwang: This change just needs your OWNERS approval for the one file in chrome/renderer/media.
6 years, 1 month ago (2014-11-21 00:15:27 UTC) #3
xhwang
media lgtm
6 years, 1 month ago (2014-11-21 00:19:43 UTC) #4
anujsharma
Thanks miu and xhwang for lgtm.
6 years, 1 month ago (2014-11-21 03:43:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/736233003/1
6 years, 1 month ago (2014-11-21 03:44:58 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-21 05:11:29 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 05:12:10 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/69ac8f09df487a1cab533e888632c2d8adc16cbb
Cr-Commit-Position: refs/heads/master@{#305174}

Powered by Google App Engine
This is Rietveld 408576698