Issue 73623004: Make DatabaseTask inherit from WebTask

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 73623004: Make DatabaseTask inherit from WebTask (Closed)

Created:
7 years, 1 month ago by jochen (gone - plz use gerrit)

Modified:
7 years, 1 month ago

Reviewers:
kinuko, michaeln, abarth-chromium

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Make DatabaseTask inherit from WebTask The goal is to implement DatabaseThread in terms of WebThread, and this is a first step into that direction. BUG=301514 R=michaeln@chromium.org,abarth@chromium.org,kinuko@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162214

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -4 lines)			Patch
M	Source/modules/webdatabase/DatabaseTask.h	View	2 chunks	+3 lines, -2 lines	1 comment	Download
M	Source/modules/webdatabase/DatabaseTask.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/webdatabase/DatabaseThread.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/73623004/1

7 years, 1 month ago (2013-11-18 16:29:18 UTC) #3

michaeln

lgtm2 https://codereview.chromium.org/73623004/diff/1/Source/modules/webdatabase/DatabaseTask.h File Source/modules/webdatabase/DatabaseTask.h (right): https://codereview.chromium.org/73623004/diff/1/Source/modules/webdatabase/DatabaseTask.h#newcode35 Source/modules/webdatabase/DatabaseTask.h:35: #include "platform/Task.h" Looks like all you need here ...

7 years, 1 month ago (2013-11-18 17:16:29 UTC) #4

Message was sent while issue was closed.

Change committed as 162214

Expand Messages | Collapse Messages