Issue 73623003: Remove SyncSchedulerImpl::OnShouldStopSyncingPermanently

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 73623003: Remove SyncSchedulerImpl::OnShouldStopSyncingPermanently (Closed)

Created:
7 years, 1 month ago by pavely

Modified:
7 years, 1 month ago

Reviewers:
rlarocque

CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@FreshToken2.Step1

Visibility:
Public.

Remove SyncSchedulerImpl::OnShouldStopSyncingPermanently Nobody calls it anyway. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235696

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -34 lines)			Patch
M	sync/engine/sync_scheduler_impl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sync/engine/sync_scheduler_impl.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	sync/engine/syncer_proto_util_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sync/engine/syncer_unittest.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sync/sessions/sync_session.h	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	sync/sessions/sync_session_unittest.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sync/test/engine/fake_sync_scheduler.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sync/test/engine/fake_sync_scheduler.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sync/test/engine/syncer_command_test.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sync/test/engine/syncer_command_test.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

rlarocque

I was curious about when this first became obsolete. I think the CL was way ...

7 years, 1 month ago (2013-11-15 21:52:06 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/73623003/1

7 years, 1 month ago (2013-11-15 22:59:14 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/73623003/1

7 years, 1 month ago (2013-11-16 01:29:30 UTC) #4

Message was sent while issue was closed.

Change committed as 235696