Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Issue 73623002: Fix broken pipe caused by commands in toolchain.gypi. (Closed)

Created:
7 years, 1 month ago by Yuta Kitamura
Modified:
7 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Fix broken pipe caused by commands in toolchain.gypi. I sometimes observe broken pipe errors when I run gyp, which causes the gyp process to fail. This seems to happen if gyp is executed under heavy I/O pressure. This change removes the pipes by replacing "echo |" with "< /dev/null". Technically these are not the same, because "echo |" prints a newline while "< /dev/null" doesn't, but this difference is not significant in the context of the commands in toolchain.gypi. BUG= R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17836

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M build/toolchain.gypi View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yuta Kitamura
Hi jkummerow, could you review this? I'm not a committer in V8, so if you ...
7 years, 1 month ago (2013-11-15 04:02:11 UTC) #1
Jakob Kummerow
LGTM. FWIW, I've never seens those pipes break, but if this helps... fine.
7 years, 1 month ago (2013-11-18 14:30:55 UTC) #2
Jakob Kummerow
7 years, 1 month ago (2013-11-18 14:32:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17836 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698