Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Side by Side Diff: net/quic/quic_connection.cc

Issue 736053002: Remove a QUIC LOG(DFATAL) that validly occurs when two packets are (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Tighten_up_QUIC_LOG_DFATAL_80120917
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_connection.h" 5 #include "net/quic/quic_connection.h"
6 6
7 #include <string.h> 7 #include <string.h>
8 #include <sys/types.h> 8 #include <sys/types.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 1580 matching lines...) Expand 10 before | Expand all | Expand 10 after
1591 // The caller of this function is responsible for checking CanWrite(). 1591 // The caller of this function is responsible for checking CanWrite().
1592 if (packet.serialized_packet.packet == nullptr) { 1592 if (packet.serialized_packet.packet == nullptr) {
1593 LOG(DFATAL) 1593 LOG(DFATAL)
1594 << "packet.serialized_packet.packet == nullptr in to SendOrQueuePacket"; 1594 << "packet.serialized_packet.packet == nullptr in to SendOrQueuePacket";
1595 return; 1595 return;
1596 } 1596 }
1597 1597
1598 sent_entropy_manager_.RecordPacketEntropyHash( 1598 sent_entropy_manager_.RecordPacketEntropyHash(
1599 packet.serialized_packet.sequence_number, 1599 packet.serialized_packet.sequence_number,
1600 packet.serialized_packet.entropy_hash); 1600 packet.serialized_packet.entropy_hash);
1601 LOG_IF(DFATAL, !queued_packets_.empty() && !writer_->IsWriteBlocked())
1602 << "Packets should only be left queued if we're write blocked.";
1603 if (!WritePacket(&packet)) { 1601 if (!WritePacket(&packet)) {
1604 queued_packets_.push_back(packet); 1602 queued_packets_.push_back(packet);
1605 } 1603 }
1606 } 1604 }
1607 1605
1608 void QuicConnection::UpdateStopWaiting(QuicStopWaitingFrame* stop_waiting) { 1606 void QuicConnection::UpdateStopWaiting(QuicStopWaitingFrame* stop_waiting) {
1609 stop_waiting->least_unacked = GetLeastUnacked(); 1607 stop_waiting->least_unacked = GetLeastUnacked();
1610 stop_waiting->entropy_hash = sent_entropy_manager_.GetCumulativeEntropy( 1608 stop_waiting->entropy_hash = sent_entropy_manager_.GetCumulativeEntropy(
1611 stop_waiting->least_unacked - 1); 1609 stop_waiting->least_unacked - 1);
1612 } 1610 }
(...skipping 455 matching lines...) Expand 10 before | Expand all | Expand 10 after
2068 } 2066 }
2069 for (size_t i = 0; i < retransmittable_frames->frames().size(); ++i) { 2067 for (size_t i = 0; i < retransmittable_frames->frames().size(); ++i) {
2070 if (retransmittable_frames->frames()[i].type == CONNECTION_CLOSE_FRAME) { 2068 if (retransmittable_frames->frames()[i].type == CONNECTION_CLOSE_FRAME) {
2071 return true; 2069 return true;
2072 } 2070 }
2073 } 2071 }
2074 return false; 2072 return false;
2075 } 2073 }
2076 2074
2077 } // namespace net 2075 } // namespace net
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698