Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Side by Side Diff: src/typing.cc

Issue 736043002: Do not bailout from optimizing functions that use f(x, arguments) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove Lookup Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/typing.h" 5 #include "src/typing.h"
6 6
7 #include "src/frames.h" 7 #include "src/frames.h"
8 #include "src/frames-inl.h" 8 #include "src/frames-inl.h"
9 #include "src/ostreams.h" 9 #include "src/ostreams.h"
10 #include "src/parser.h" // for CompileTimeValue; TODO(rossberg): should move 10 #include "src/parser.h" // for CompileTimeValue; TODO(rossberg): should move
(...skipping 492 matching lines...) Expand 10 before | Expand all | Expand 10 after
503 RECURSE(Visit(expr->obj())); 503 RECURSE(Visit(expr->obj()));
504 RECURSE(Visit(expr->key())); 504 RECURSE(Visit(expr->key()));
505 505
506 // We don't know anything about the result type. 506 // We don't know anything about the result type.
507 } 507 }
508 508
509 509
510 void AstTyper::VisitCall(Call* expr) { 510 void AstTyper::VisitCall(Call* expr) {
511 // Collect type feedback. 511 // Collect type feedback.
512 RECURSE(Visit(expr->expression())); 512 RECURSE(Visit(expr->expression()));
513 FeedbackVectorICSlot slot = expr->CallFeedbackSlot();
514 expr->set_is_uninitialized(oracle()->CallIsUninitialized(slot));
513 if (!expr->expression()->IsProperty() && 515 if (!expr->expression()->IsProperty() &&
514 expr->IsUsingCallFeedbackSlot(isolate()) && 516 expr->IsUsingCallFeedbackSlot(isolate()) &&
515 oracle()->CallIsMonomorphic(expr->CallFeedbackSlot())) { 517 oracle()->CallIsMonomorphic(slot)) {
516 expr->set_target(oracle()->GetCallTarget(expr->CallFeedbackSlot())); 518 expr->set_target(oracle()->GetCallTarget(slot));
517 Handle<AllocationSite> site = 519 Handle<AllocationSite> site = oracle()->GetCallAllocationSite(slot);
518 oracle()->GetCallAllocationSite(expr->CallFeedbackSlot());
519 expr->set_allocation_site(site); 520 expr->set_allocation_site(site);
520 } 521 }
521 522
522 ZoneList<Expression*>* args = expr->arguments(); 523 ZoneList<Expression*>* args = expr->arguments();
523 for (int i = 0; i < args->length(); ++i) { 524 for (int i = 0; i < args->length(); ++i) {
524 Expression* arg = args->at(i); 525 Expression* arg = args->at(i);
525 RECURSE(Visit(arg)); 526 RECURSE(Visit(arg));
526 } 527 }
527 528
528 VariableProxy* proxy = expr->expression()->AsVariableProxy(); 529 VariableProxy* proxy = expr->expression()->AsVariableProxy();
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
783 void AstTyper::VisitModuleUrl(ModuleUrl* module) { 784 void AstTyper::VisitModuleUrl(ModuleUrl* module) {
784 } 785 }
785 786
786 787
787 void AstTyper::VisitModuleStatement(ModuleStatement* stmt) { 788 void AstTyper::VisitModuleStatement(ModuleStatement* stmt) {
788 RECURSE(Visit(stmt->body())); 789 RECURSE(Visit(stmt->body()));
789 } 790 }
790 791
791 792
792 } } // namespace v8::internal 793 } } // namespace v8::internal
OLDNEW
« src/ast.h ('K') | « src/type-info.cc ('k') | test/mjsunit/regress/regress-3709.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698