PepperVideoSourceHost: Use natural_size instead of visible_rect.size

PepperVideoSourceHost: Use natural_size instead of visible_rect.size

media::VideoFrame may be scaled lazily by having natural_size < visible_rect.size. PepperVideoSourceHost currently ignores this and sends the full resolution to the effects plugin anyway. This CL makes PepperVideoSourceHost respect natural_size by downscaling the frame if necessary before sending it to the effects plugin.

TEST=Open the camera in 1080p with e.g. https://apprtc.appspot.com/?debug=loopback&video=minWidth=1920,minHeight=1080. Join a Hangouts. Natural size will be set to 720p and trigger a rescaling.

Committed: https://crrev.com/e70be8b8758721593fa462ed08b2bcd63c21e6d1
Cr-Commit-Position: refs/heads/master@{#305031}

[magjed_chromium, 2014-11-19 17:22:06]

magjed@chromium.org changed reviewers:
+ perkj@chromium.org

[magjed_chromium, 2014-11-19 17:22:18]

perkj: Can you take a look?

[perkj_chrome, 2014-11-20 06:56:46]

On 2014/11/19 17:22:18, magjed wrote:
> perkj: Can you take a look?

lgtm. but please describe  how to test that this works in TEST=

[magjed_chromium, 2014-11-20 11:56:58]

magjed@chromium.org changed reviewers:
+ bbudge@chromium.org

[magjed_chromium, 2014-11-20 11:57:16]

bbudge: Can you please take a look?

[bbudge, 2014-11-20 15:21:55]

https://codereview.chromium.org/736033002/diff/1/content/renderer/pepper/pepp...
File content/renderer/pepper/pepper_video_source_host.cc (right):

https://codereview.chromium.org/736033002/diff/1/content/renderer/pepper/pepp...
content/renderer/pepper/pepper_video_source_host.cc:213: // The resolution of
the frames don't change frequently, so don't keep any
nit: awkward grammar. How about this?
// Frame resolution doesn't change frequently, so...

https://codereview.chromium.org/736033002/diff/1/content/renderer/pepper/pepp...
content/renderer/pepper/pepper_video_source_host.cc:215: scaled_frame_ = NULL;
This comment makes me wonder why you keep scaled_frame_ after you send the
reply? Is it likely that there will be a run of scalings, so you keep it to
avoid reallocating?

[magjed_chromium, 2014-11-20 15:38:44]

https://codereview.chromium.org/736033002/diff/1/content/renderer/pepper/pepp...
File content/renderer/pepper/pepper_video_source_host.cc (right):

https://codereview.chromium.org/736033002/diff/1/content/renderer/pepper/pepp...
content/renderer/pepper/pepper_video_source_host.cc:213: // The resolution of
the frames don't change frequently, so don't keep any
On 2014/11/20 15:21:55, bbudge wrote:
> nit: awkward grammar. How about this?
> // Frame resolution doesn't change frequently, so...

Done.

https://codereview.chromium.org/736033002/diff/1/content/renderer/pepper/pepp...
content/renderer/pepper/pepper_video_source_host.cc:215: scaled_frame_ = NULL;
On 2014/11/20 15:21:55, bbudge wrote:
> This comment makes me wonder why you keep scaled_frame_ after you send the
> reply? Is it likely that there will be a run of scalings, so you keep it to
> avoid reallocating?

Yes exactly. last_frame_->visible_rect().size and last_frame_.natural_size()
typically don't change between consecutive frames, at least for long runs. So if
we need to scale this frame we will most likely need to scale the next frame as
well.

[bbudge, 2014-11-20 16:06:35]

lgtm

[magjed_chromium, 2014-11-20 16:07:01]

The CQ bit was checked by magjed@chromium.org

[commit-bot: I haz the power, 2014-11-20 16:07:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/736033002/20001

[commit-bot: I haz the power, 2014-11-20 17:48:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-20 17:49:15]

Patchset 2 (id:??) landed as
https://crrev.com/e70be8b8758721593fa462ed08b2bcd63c21e6d1
Cr-Commit-Position: refs/heads/master@{#305031}