Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 736023002: Add conversion rule for aria-grabbed attributes. (Closed)

Created:
6 years, 1 month ago by je_julie(Not used)
Modified:
5 years, 11 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add conversion rule for aria-grabbed attributes. This patch adds conversion rule for aria-grabbed attribute and exposes it only when it's defined. The related patch is https://codereview.chromium.org/736943002/ BUG=98817 Committed: https://crrev.com/53f2a6ca14892c5f787db76602a1742af459466f Cr-Commit-Position: refs/heads/master@{#313349}

Patch Set 1 #

Patch Set 2 : Update test results #

Total comments: 2

Patch Set 3 : Update Comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -7 lines) Patch
M content/browser/accessibility/accessibility_tree_formatter_mac.mm View 1 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 3 chunks +13 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-expanded.html View 1 1 chunk +4 lines, -4 lines 0 comments Download
A content/test/data/accessibility/aria/aria-grabbed.html View 1 1 chunk +15 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-grabbed-expected-android.txt View 1 1 chunk +14 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-grabbed-expected-mac.txt View 1 1 chunk +14 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-grabbed-expected-win.txt View 1 1 chunk +14 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/blue.png View 1 Binary file 0 comments Download
M ui/accessibility/ax_enums.idl View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M ui/accessibility/ax_node_data.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
je_julie(Not used)
Hi Dominic, This patch adds conversion rule for aria-grabbed at chromium side. PTAL.
5 years, 11 months ago (2015-01-25 16:26:55 UTC) #3
dmazzoni
lgtm https://codereview.chromium.org/736023002/diff/40001/ui/accessibility/ax_enums.idl File ui/accessibility/ax_enums.idl (right): https://codereview.chromium.org/736023002/diff/40001/ui/accessibility/ax_enums.idl#newcode350 ui/accessibility/ax_enums.idl:350: // grabbed attributes Make it a short sentence, ...
5 years, 11 months ago (2015-01-27 06:59:41 UTC) #4
je_julie(Not used)
Thanks for your review. I updated comment. Can I commit it? https://codereview.chromium.org/736023002/diff/40001/ui/accessibility/ax_enums.idl File ui/accessibility/ax_enums.idl (right): ...
5 years, 11 months ago (2015-01-27 16:00:29 UTC) #5
dmazzoni
Yes. In general if you get an lgtm with comments that means you're free to ...
5 years, 11 months ago (2015-01-27 19:49:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/736023002/60001
5 years, 11 months ago (2015-01-27 19:50:45 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 11 months ago (2015-01-27 20:40:15 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 20:41:14 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/53f2a6ca14892c5f787db76602a1742af459466f
Cr-Commit-Position: refs/heads/master@{#313349}

Powered by Google App Engine
This is Rietveld 408576698