Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 736003002: Correctly escape RegExp source. (Closed)

Created:
6 years, 1 month ago by Yang
Modified:
6 years, 1 month ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@regexpref
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed comments #

Patch Set 3 : update webkit expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -54 lines) Patch
M src/accessors.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/accessors.cc View 1 1 chunk +89 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 2 chunks +9 lines, -11 lines 0 comments Download
M src/json-stringifier.h View 3 chunks +1 line, -21 lines 0 comments Download
M src/objects.h View 1 2 chunks +8 lines, -6 lines 0 comments Download
M src/objects.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M test/mjsunit/compiler/literals.js View 1 chunk +2 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-3229.js View 1 chunk +26 lines, -0 lines 0 comments Download
M test/webkit/fast/regex/toString-expected.txt View 1 2 2 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
6 years, 1 month ago (2014-11-19 13:34:35 UTC) #1
Yang
On 2014/11/19 13:34:35, Yang wrote: ping
6 years, 1 month ago (2014-11-21 08:28:16 UTC) #2
ulan
lgtm https://codereview.chromium.org/736003002/diff/1/src/accessors.cc File src/accessors.cc (right): https://codereview.chromium.org/736003002/diff/1/src/accessors.cc#newcode348 src/accessors.cc:348: } DCHECK_EQ(result.length(), d);
6 years, 1 month ago (2014-11-21 09:19:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/736003002/20001
6 years, 1 month ago (2014-11-21 09:48:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/1336)
6 years, 1 month ago (2014-11-21 10:06:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/736003002/40001
6 years, 1 month ago (2014-11-21 10:22:27 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 10:50:23 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001)

Powered by Google App Engine
This is Rietveld 408576698