Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 735963002: Revert of cc: Test one copy in mask unit tests (Closed)

Created:
6 years, 1 month ago by Michael Achenbach
Modified:
6 years, 1 month ago
Reviewers:
reveman, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Test one copy in mask unit tests (patchset #1 id:1 of https://codereview.chromium.org/739003002/) Reason for revert: [Sheriff] Speculative revert for making PixelResourceTest/LayerTreeHostMasksPixelTest.MaskOfClippedLayer/2 flaky. Starting here: http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/18677 Original issue's description: > cc: Test one copy in mask unit tests > > R=reveman@chromium.org > > Committed: https://crrev.com/1f1b197adbd5fdf449229646b26835f0df71e76f > Cr-Commit-Position: refs/heads/master@{#304708} TBR=reveman@chromium.org,enne@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a272dd400623eec4e9a82919e2016bb02ace0654 Cr-Commit-Position: refs/heads/master@{#304786}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M cc/test/layer_tree_pixel_resource_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/test/test_in_process_context_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Michael Achenbach
Created Revert of cc: Test one copy in mask unit tests
6 years, 1 month ago (2014-11-19 08:40:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/735963002/1
6 years, 1 month ago (2014-11-19 08:40:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-19 08:41:04 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a272dd400623eec4e9a82919e2016bb02ace0654 Cr-Commit-Position: refs/heads/master@{#304786}
6 years, 1 month ago (2014-11-19 08:41:51 UTC) #4
Michael Achenbach
Maybe other failures are connected too like: http://build.chromium.org/p/chromium.win/buildstatus?builder=XP%20Tests%20%281%29&number=33953 http://build.chromium.org/p/chromium.win/buildstatus?builder=Win7%20Tests%20%281%29&number=33488
6 years, 1 month ago (2014-11-19 08:44:30 UTC) #5
Michael Achenbach
6 years, 1 month ago (2014-11-19 12:36:26 UTC) #6
Message was sent while issue was closed.
This revert has fixed the problems.

Powered by Google App Engine
This is Rietveld 408576698