Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 735863003: Fix/suppress unittests broken on Android (Closed)

Created:
6 years, 1 month ago by Ian Cullinan
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Fix/suppress unittests broken on Android cctest/test-threads/ThreadJoinSelf is suppressed for Android, but the test has since been moved to unittests/Thread.SelfJoin. Move the suppression to unittests.status. unittests/ThreadLocalStorageTest.DoTest fails on older Android devices as it assumes the availability of more TLS slots than many devices implement. Test a smaller number of slots (32) on Android. Remove old suppression of test-platform-tls/FastTLS (which no longer exists). cctest/test-mark-compact/RegressJoinThreadsOnIsolateDeinit can't deal with shared mappings. Check for 's' instead of '-'. BUG=v8:3706 LOG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M test/cctest/cctest.status View 1 chunk +0 lines, -6 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/base/platform/platform-unittest.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/unittests/unittests.status View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ian Cullinan
Hi Michael, PTAL at this CL to address some of the test failures reported in ...
6 years, 1 month ago (2014-11-18 23:51:50 UTC) #2
Michael Starzinger
LGTM from my end, but Ulan (CCed him) is our resident Android expert.
6 years ago (2014-11-24 09:03:44 UTC) #4
ulan
lgtm
6 years ago (2014-11-24 09:47:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/735863003/1
6 years ago (2014-11-24 17:38:26 UTC) #7
commit-bot: I haz the power
6 years ago (2014-11-24 18:06:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698