Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: mojo/shell/dynamic_application_loader.cc

Issue 735863002: Emit an error log line when attempting to connect to an app at an invalid URL. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Check that specified URLs for applications are good. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« mojo/shell/desktop/mojo_main.cc ('K') | « mojo/shell/desktop/mojo_main.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/dynamic_application_loader.cc
diff --git a/mojo/shell/dynamic_application_loader.cc b/mojo/shell/dynamic_application_loader.cc
index e1baea487dd0ed42dd5a15cc3fab5e2291bca6e9..612bd0d148cdb9d31a8730b6f4480e486d18ce7e 100644
--- a/mojo/shell/dynamic_application_loader.cc
+++ b/mojo/shell/dynamic_application_loader.cc
@@ -211,6 +211,8 @@ DynamicApplicationLoader::~DynamicApplicationLoader() {
void DynamicApplicationLoader::RegisterContentHandler(
const std::string& mime_type,
const GURL& content_handler_url) {
+ DCHECK(content_handler_url.possibly_invalid_spec().size() > 0)
Aaron Boodman 2014/11/20 21:53:59 DCHECK(content_handler_url.is_valid())
azani 2014/11/20 22:10:03 Done.
+ << "Content handler URL is invalid for mime type " << mime_type;
mime_type_to_url_[mime_type] = content_handler_url;
}
« mojo/shell/desktop/mojo_main.cc ('K') | « mojo/shell/desktop/mojo_main.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698