Emit an error log line when attempting to connect to an app at an invalid URL.

mojo/application_manager/application_manager.cc

Index: mojo/application_manager/application_manager.cc
diff --git a/mojo/application_manager/application_manager.cc b/mojo/application_manager/application_manager.cc
index 75ef7a76694b24773a65b38e644d83bd901d1ce9..c6727c548dd8599cbc321efa36445a535d5f37b6 100644
--- a/mojo/application_manager/application_manager.cc
+++ b/mojo/application_manager/application_manager.cc
@@ -98,10 +98,14 @@ class ApplicationManager::ShellImpl : public InterfaceImpl<Shell> {
   void ConnectToApplication(
       const String& app_url,
       InterfaceRequest<ServiceProvider> in_service_provider) override {
+    GURL app_gurl(app_url.get());

[Aaron Boodman, 2014/11/19 20:29:28]

If we were going to check the URL before requesting it, then I think it should
be in ApplicationManager::ConnectToApplication() instead because that's a better
chokepoint.

But I think we should probably not check the URL before requesting it, and just
use possibly_invalid_spec() instead.

+    if (!app_gurl.is_valid()) {
+      LOG(ERROR) << "Error: \"" << app_url << "\" is not a valid URL.";
+    }
     ServiceProviderPtr out_service_provider;
     out_service_provider.Bind(in_service_provider.PassMessagePipe());
     manager_->ConnectToApplication(
-        app_url.To<GURL>(), url_, out_service_provider.Pass());
+        app_gurl, url_, out_service_provider.Pass());
   }
 
   const GURL& url() const { return url_; }