Emit an error log line when attempting to connect to an app at an invalid URL.

mojo/application_manager/application_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/application_manager/application_manager.h"
 
 #include <stdio.h>
 
 #include "base/bind.h"
 #include "base/lazy_instance.h"
@@ skipping 82 matching lines @@
     client()->AcceptConnection(String::From(requestor_url),
                                service_provider.Pass());
   }
 
   // ServiceProvider implementation:
   void ConnectToApplication(
       const String& app_url,
       InterfaceRequest<ServiceProvider> in_service_provider) override {
     ServiceProviderPtr out_service_provider;
     out_service_provider.Bind(in_service_provider.PassMessagePipe());
-    manager_->ConnectToApplication(
-        app_url.To<GURL>(), url_, out_service_provider.Pass());
+    GURL app_gurl(app_url);
+    if (!app_gurl.is_valid()) {
+      LOG(ERROR) << "Error: invalid URL: " << app_url;
+      return;
+    }
+    manager_->ConnectToApplication(app_gurl, url_, out_service_provider.Pass());
   }
 
   const GURL& url() const { return url_; }
 
  private:
   void OnConnectionError() override { manager_->OnShellImplError(this); }
 
   ApplicationManager* const manager_;
   const GURL url_;
 
@@ skipping 53 matching lines @@
   static base::LazyInstance<ApplicationManager> instance =
       LAZY_INSTANCE_INITIALIZER;
   has_created_instance = true;
   return &instance.Get();
 }
 
 void ApplicationManager::ConnectToApplication(
     const GURL& url,
     const GURL& requestor_url,
     ServiceProviderPtr service_provider) {
+  DCHECK(url.is_valid());
   URLToShellImplMap::const_iterator shell_it = url_to_shell_impl_.find(url);
   if (shell_it != url_to_shell_impl_.end()) {
     ConnectToClient(
         shell_it->second, url, requestor_url, service_provider.Pass());
     return;
   }
 
   scoped_refptr<LoadCallbacksImpl> callbacks(
       new LoadCallbacksImpl(weak_ptr_factory_.GetWeakPtr(),
                             url,
@@ skipping 128 matching lines @@
   StubServiceProvider* stub_sp = new StubServiceProvider;
   ServiceProviderPtr spp;
   BindToProxy(stub_sp, &spp);
   ConnectToApplication(application_url, GURL(), spp.Pass());
   MessagePipe pipe;
   stub_sp->GetRemoteServiceProvider()->ConnectToService(interface_name,
                                                         pipe.handle1.Pass());
   return pipe.handle0.Pass();
 }
 }  // namespace mojo