Emit an error log line when attempting to connect to an app at an invalid URL.

mojo/shell/dynamic_application_loader.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/shell/dynamic_application_loader.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
@@ skipping 142 matching lines @@
   }
 
   ~NetworkLoader() override {
     if (!file_.empty())
       base::DeleteFile(file_, false);
   }
 
  private:
   void OnLoadComplete(URLResponsePtr response) {
     if (response->error) {
-      LOG(ERROR) << "Error (" << response->error->code << ": "
-                 << response->error->description << ") while fetching "
-                 << response->url;
+      if (response->url->is_valid()) {
+        LOG(ERROR) << "Error (" << response->error->code << ": "
+                   << response->error->description << ") while fetching "
+                   << response->url;
+      } else {
+        // If the URL was not valid, it's not possible to get the spec.

[Aaron Boodman, 2014/11/19 20:29:28]

I think you can use possibly_invalid_spec() here.

[azani, 2014/11/19 23:08:54]

Nope. Also returns an empty string. It looks like if the URL cannot be parsed,
GURL simply leaves spec_ (the private variable it uses to hold the spec) as an
empty string. It looks like that is because the way spec_ is built is by parsing
the input_spec and then reconstructing a spec.

+        LOG(ERROR) << "Error (" << response->error->code << ": "
+                   << response->error->description << ")";
+      }
       LoaderComplete();
       return;
     }
 
     MimeTypeToURLMap::iterator iter =
         mime_type_to_url_->find(response->mime_type);
     if (iter != mime_type_to_url_->end()) {
       load_callbacks_->LoadWithContentHandler(iter->second, response.Pass());
       return;
     }
@@ skipping 77 matching lines @@
   // TODO(darin): What should we do about service errors? This implies that
   // the app closed its handle to the service manager. Maybe we don't care?
 }
 
 void DynamicApplicationLoader::LoaderComplete(Loader* loader) {
   loaders_.erase(std::find(loaders_.begin(), loaders_.end(), loader));
 }
 
 }  // namespace shell
 }  // namespace mojo