Emit an error log line when attempting to connect to an app at an invalid URL.

mojo/application_manager/application_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/application_manager/application_manager.h"
 
 #include <stdio.h>
 
 #include "base/bind.h"
 #include "base/lazy_instance.h"
@@ skipping 80 matching lines @@
   void ConnectToClient(const GURL& requestor_url,
                        ServiceProviderPtr service_provider) {
     client()->AcceptConnection(String::From(requestor_url),
                                service_provider.Pass());
   }
 
   // ServiceProvider implementation:
   void ConnectToApplication(
       const String& app_url,
       InterfaceRequest<ServiceProvider> in_service_provider) override {
+    GURL app_gurl(app_url.get());

[Aaron Boodman, 2014/11/19 20:29:28]

If we were going to check the URL before requesting it, then I think it should
be in ApplicationManager::ConnectToApplication() instead because that's a better
chokepoint.

But I think we should probably not check the URL before requesting it, and just
use possibly_invalid_spec() instead.

+    if (!app_gurl.is_valid()) {
+      LOG(ERROR) << "Error: \"" << app_url << "\" is not a valid URL.";
+    }
     ServiceProviderPtr out_service_provider;
     out_service_provider.Bind(in_service_provider.PassMessagePipe());
     manager_->ConnectToApplication(
-        app_url.To<GURL>(), url_, out_service_provider.Pass());
+        app_gurl, url_, out_service_provider.Pass());
   }
 
   const GURL& url() const { return url_; }
 
  private:
   void OnConnectionError() override { manager_->OnShellImplError(this); }
 
   ApplicationManager* const manager_;
   const GURL url_;
 
@@ skipping 201 matching lines @@
   StubServiceProvider* stub_sp = new StubServiceProvider;
   ServiceProviderPtr spp;
   BindToProxy(stub_sp, &spp);
   ConnectToApplication(application_url, GURL(), spp.Pass());
   MessagePipe pipe;
   stub_sp->GetRemoteServiceProvider()->ConnectToService(interface_name,
                                                         pipe.handle1.Pass());
   return pipe.handle0.Pass();
 }
 }  // namespace mojo