Emit an error log line when attempting to connect to an app at an invalid URL.

mojo/application_manager/application_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/application_manager/application_manager.h"
 
 #include <stdio.h>
 
 #include "base/bind.h"
 #include "base/lazy_instance.h"
@@ skipping 128 matching lines @@
         binding_(this) {
     binding_.set_error_handler(this);
   }
 
   // Shell implementation:
   void ConnectToApplication(
       const String& app_url,
       InterfaceRequest<ServiceProvider> in_service_provider) override {
     ServiceProviderPtr out_service_provider;
     out_service_provider.Bind(in_service_provider.PassMessagePipe());
-    manager_->ConnectToApplication(
-        app_url.To<GURL>(), url_, out_service_provider.Pass());
+    GURL app_gurl(app_url);
+    if (!app_gurl.is_valid()) {
+      LOG(ERROR) << "Error: invalid URL: " << app_url;
+      return;
+    }
+    manager_->ConnectToApplication(app_gurl, url_, out_service_provider.Pass());
   }
 
   // ErrorHandler implementation:
   void OnConnectionError() override { manager_->OnShellImplError(this); }
 
   ApplicationManager* const manager_;
   const GURL requested_url_;
   const GURL url_;
   Binding<Shell> binding_;
 
@@ skipping 61 matching lines @@
 
 void ApplicationManager::TerminateShellConnections() {
   STLDeleteValues(&url_to_shell_impl_);
   STLDeleteElements(&content_shell_impls_);
 }
 
 void ApplicationManager::ConnectToApplication(
     const GURL& requested_url,
     const GURL& requestor_url,
     ServiceProviderPtr service_provider) {
+  DCHECK(requested_url.is_valid());
   ApplicationLoader* loader = GetLoaderForURL(requested_url,
                                               DONT_INCLUDE_DEFAULT_LOADER);
   if (loader) {
     ConnectToApplicationImpl(requested_url, requested_url, requestor_url,
                              service_provider.Pass(), loader);
     return;
   }
 
   GURL resolved_url = delegate_->ResolveURL(requested_url);
   loader = GetLoaderForURL(resolved_url, INCLUDE_DEFAULT_LOADER);
@@ skipping 193 matching lines @@
   return pipe.handle0.Pass();
 }
 
 Array<String> ApplicationManager::GetArgsForURL(const GURL& url) {
   URLToArgsMap::const_iterator args_it = url_to_args_.find(url);
   if (args_it != url_to_args_.end())
     return Array<String>::From(args_it->second);
   return Array<String>();
 }
 }  // namespace mojo