Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 735763002: v8::String::Concat must not throw. (Closed)

Created:
6 years, 1 month ago by Yang
Modified:
6 years, 1 month ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

v8::String::Concat must not throw. R=dcarney@chromium.org BUG=chromium:420240 LOG=Y API=v8::String::Concat may return empty handle on overflow. Committed: https://chromium.googlesource.com/v8/v8/+/9182f51190732ea084d50f4b7a999b95774e0a14

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -7 lines) Patch
M src/api.cc View 1 chunk +5 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 4 chunks +25 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Yang
6 years, 1 month ago (2014-11-18 15:16:47 UTC) #1
dcarney
lgtm
6 years, 1 month ago (2014-11-18 15:23:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/735763002/1
6 years, 1 month ago (2014-11-18 15:24:03 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 15:51:11 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698