Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5568)

Unified Diff: chrome/browser/ui/views/download/download_item_view.cc

Issue 73573002: Safebrowsing aura linux_redux compile fixes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/download/download_item_view.cc
diff --git a/chrome/browser/ui/views/download/download_item_view.cc b/chrome/browser/ui/views/download/download_item_view.cc
index fb71889dac70b09a0971bb746204f3743162d147..3b57d13dffcc616cbc1120ab9afe7fa0ad515b3a 100644
--- a/chrome/browser/ui/views/download/download_item_view.cc
+++ b/chrome/browser/ui/views/download/download_item_view.cc
@@ -870,6 +870,7 @@ void DownloadItemView::OpenDownload() {
}
bool DownloadItemView::BeginDownloadFeedback() {
+#if defined(FULL_SAFE_BROWSING)
SafeBrowsingService* sb_service = g_browser_process->safe_browsing_service();
if (!sb_service)
return false;
@@ -886,6 +887,10 @@ bool DownloadItemView::BeginDownloadFeedback() {
download());
// WARNING: we are deleted at this point. Don't access 'this'.
return true;
+#else
+ NOTREACHED();
+ return false;
+#endif
}
void DownloadItemView::LoadIcon() {
@@ -1095,10 +1100,12 @@ void DownloadItemView::ClearWarningDialog() {
void DownloadItemView::ShowWarningDialog() {
DCHECK(mode_ != DANGEROUS_MODE && mode_ != MALICIOUS_MODE);
time_download_warning_shown_ = base::Time::Now();
+#if defined(FULL_SAFE_BROWSING)
if (model_.ShouldAllowDownloadFeedback()) {
safe_browsing::DownloadFeedbackService::RecordEligibleDownloadShown(
download()->GetDangerType());
}
+#endif
mode_ = model_.MightBeMalicious() ? MALICIOUS_MODE : DANGEROUS_MODE;
body_state_ = NORMAL;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698