Conditional flags for tests - set JS stack size for simulators.

tools/testrunner/local/testsuite.py

 # Copyright 2012 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
 #       disclaimer in the documentation and/or other materials provided
@@ skipping 118 matching lines @@
       slow = False
       pass_fail = False
       testname = self.CommonTestName(t)
       if testname in self.rules:
         used_rules.add(testname)
         # Even for skipped tests, as the TestCase object stays around and
         # PrintReport() uses it.
         t.outcomes = self.rules[testname]
         if statusfile.DoSkip(t.outcomes):
           continue  # Don't add skipped tests to |filtered|.
+        for outcome in t.outcomes:

[Michael Achenbach, 2014/11/20 08:38:31]

I'd rather put this code into a new method/loop right after the call side of
this method:
https://code.google.com/p/chromium/codesearch#chromium/src/v8/tools/run-tests...

This method should be refactored anyway - lets restrict its concern to filtering
and outcomes definition - not also flags.

The code piece above currently only applies to "if testname in self.rules" and
not to the condition about wildcards below. But the feature should also be
available for wildcard rules I guess?

+          if outcome.startswith('Flags: '):
+            t.flags += outcome[7:].split()
         flaky = statusfile.IsFlaky(t.outcomes)
         slow = statusfile.IsSlow(t.outcomes)
         pass_fail = statusfile.IsPassOrFail(t.outcomes)
       skip = False
       for rule in self.wildcards:
         assert rule[-1] == '*'
         if testname.startswith(rule[:-1]):
           used_rules.add(rule)
           t.outcomes = self.wildcards[rule]
           if statusfile.DoSkip(t.outcomes):
@@ skipping 112 matching lines @@
     return tests
 
   def GetFlagsForTestCase(self, testcase, context):
     return (testcase.flags + ["--gtest_filter=" + testcase.path] +
             ["--gtest_random_seed=%s" % context.random_seed] +
             ["--gtest_print_time=0"] +
             context.mode_flags)
 
   def shell(self):
     return self.name