Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: content/renderer/scheduler/renderer_scheduler_impl_unittest.cc

Issue 735723005: cc: Adding creation location to debug BeginFrameArgs objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Testing on try bots. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/scheduler/renderer_scheduler_impl_unittest.cc
diff --git a/content/renderer/scheduler/renderer_scheduler_impl_unittest.cc b/content/renderer/scheduler/renderer_scheduler_impl_unittest.cc
index c1fcd5a431f09986f0fb1539362a78e2814fcccb..869a742057ad6d83a6ed221534319a152bb7e47b 100644
--- a/content/renderer/scheduler/renderer_scheduler_impl_unittest.cc
+++ b/content/renderer/scheduler/renderer_scheduler_impl_unittest.cc
@@ -41,9 +41,9 @@ class RendererSchedulerImplTest : public testing::Test {
void RunUntilIdle() { mock_task_runner_->RunUntilIdle(); }
void EnableIdleTasks() {
- scheduler_->WillBeginFrame(
- cc::BeginFrameArgs::Create(clock_->Now(), base::TimeTicks(),
- base::TimeDelta::FromMilliseconds(1000)));
+ scheduler_->WillBeginFrame(cc::BeginFrameArgs::Create(
+ BEGINFRAME_FROM_HERE, clock_->Now(), base::TimeTicks(),
+ base::TimeDelta::FromMilliseconds(1000), cc::BeginFrameArgs::NORMAL));
scheduler_->DidCommitFrameToCompositor();
}
@@ -191,9 +191,9 @@ TEST_F(RendererSchedulerImplTest, TestPostIdleTask) {
RunUntilIdle();
EXPECT_FALSE(task_run); // Shouldn't run yet as no WillBeginFrame.
- scheduler_->WillBeginFrame(
- cc::BeginFrameArgs::Create(clock_->Now(), base::TimeTicks(),
- base::TimeDelta::FromMilliseconds(1000)));
+ scheduler_->WillBeginFrame(cc::BeginFrameArgs::Create(
+ BEGINFRAME_FROM_HERE, clock_->Now(), base::TimeTicks(),
+ base::TimeDelta::FromMilliseconds(1000), cc::BeginFrameArgs::NORMAL));
RunUntilIdle();
EXPECT_FALSE(task_run); // Shouldn't run as no DidCommitFrameToCompositor.
@@ -202,9 +202,9 @@ TEST_F(RendererSchedulerImplTest, TestPostIdleTask) {
RunUntilIdle();
EXPECT_FALSE(task_run); // We missed the deadline.
- scheduler_->WillBeginFrame(
- cc::BeginFrameArgs::Create(clock_->Now(), base::TimeTicks(),
- base::TimeDelta::FromMilliseconds(1000)));
+ scheduler_->WillBeginFrame(cc::BeginFrameArgs::Create(
+ BEGINFRAME_FROM_HERE, clock_->Now(), base::TimeTicks(),
+ base::TimeDelta::FromMilliseconds(1000), cc::BeginFrameArgs::NORMAL));
clock_->AdvanceNow(base::TimeDelta::FromMilliseconds(800));
scheduler_->DidCommitFrameToCompositor();
RunUntilIdle();

Powered by Google App Engine
This is Rietveld 408576698