Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4051)

Unified Diff: cc/test/begin_frame_args_test.cc

Issue 735723005: cc: Adding creation location to debug BeginFrameArgs objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Testing on try bots. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/test/begin_frame_args_test.cc
diff --git a/cc/test/begin_frame_args_test.cc b/cc/test/begin_frame_args_test.cc
index 1c4b236f0ac6a95fdeb35b385510160507fc5c7d..7b2974867469d3803d029dedc483dff233290edb 100644
--- a/cc/test/begin_frame_args_test.cc
+++ b/cc/test/begin_frame_args_test.cc
@@ -10,63 +10,72 @@
namespace cc {
-BeginFrameArgs CreateBeginFrameArgsForTesting() {
- return CreateBeginFrameArgsForTesting(gfx::FrameTime::Now());
+BeginFrameArgs CreateBeginFrameArgsForTesting(
+ BeginFrameArgs::CreationLocation location) {
+ return CreateBeginFrameArgsForTesting(location, gfx::FrameTime::Now());
}
-BeginFrameArgs CreateBeginFrameArgsForTesting(base::TimeTicks frame_time) {
+BeginFrameArgs CreateBeginFrameArgsForTesting(
+ BeginFrameArgs::CreationLocation location,
+ base::TimeTicks frame_time) {
return BeginFrameArgs::Create(
- frame_time,
+ location, frame_time,
frame_time + (BeginFrameArgs::DefaultInterval() / 2),
- BeginFrameArgs::DefaultInterval());
+ BeginFrameArgs::DefaultInterval(), BeginFrameArgs::NORMAL);
}
-BeginFrameArgs CreateBeginFrameArgsForTesting(int64 frame_time,
- int64 deadline,
- int64 interval) {
- return BeginFrameArgs::Create(base::TimeTicks::FromInternalValue(frame_time),
- base::TimeTicks::FromInternalValue(deadline),
- base::TimeDelta::FromInternalValue(interval));
+BeginFrameArgs CreateBeginFrameArgsForTesting(
+ BeginFrameArgs::CreationLocation location,
+ int64 frame_time,
+ int64 deadline,
+ int64 interval) {
+ return BeginFrameArgs::Create(
+ location, base::TimeTicks::FromInternalValue(frame_time),
+ base::TimeTicks::FromInternalValue(deadline),
+ base::TimeDelta::FromInternalValue(interval), BeginFrameArgs::NORMAL);
}
-BeginFrameArgs CreateTypedBeginFrameArgsForTesting(
+BeginFrameArgs CreateBeginFrameArgsForTesting(
+ BeginFrameArgs::CreationLocation location,
int64 frame_time,
int64 deadline,
int64 interval,
BeginFrameArgs::BeginFrameArgsType type) {
- return BeginFrameArgs::CreateTyped(
- base::TimeTicks::FromInternalValue(frame_time),
+ return BeginFrameArgs::Create(
+ location, base::TimeTicks::FromInternalValue(frame_time),
base::TimeTicks::FromInternalValue(deadline),
- base::TimeDelta::FromInternalValue(interval),
- type);
+ base::TimeDelta::FromInternalValue(interval), type);
}
-BeginFrameArgs CreateExpiredBeginFrameArgsForTesting() {
+BeginFrameArgs CreateExpiredBeginFrameArgsForTesting(
+ BeginFrameArgs::CreationLocation location) {
base::TimeTicks now = gfx::FrameTime::Now();
- return BeginFrameArgs::Create(now,
- now - BeginFrameArgs::DefaultInterval(),
- BeginFrameArgs::DefaultInterval());
+ return BeginFrameArgs::Create(
+ location, now, now - BeginFrameArgs::DefaultInterval(),
+ BeginFrameArgs::DefaultInterval(), BeginFrameArgs::NORMAL);
}
BeginFrameArgs CreateBeginFrameArgsForTesting(
+ BeginFrameArgs::CreationLocation location,
scoped_refptr<TestNowSource> now_src) {
base::TimeTicks now = now_src->Now();
- return BeginFrameArgs::Create(now,
- now + (BeginFrameArgs::DefaultInterval() / 2),
- BeginFrameArgs::DefaultInterval());
+ return BeginFrameArgs::Create(
+ location, now, now + (BeginFrameArgs::DefaultInterval() / 2),
+ BeginFrameArgs::DefaultInterval(), BeginFrameArgs::NORMAL);
}
BeginFrameArgs CreateExpiredBeginFrameArgsForTesting(
+ BeginFrameArgs::CreationLocation location,
scoped_refptr<TestNowSource> now_src) {
base::TimeTicks now = now_src->Now();
- return BeginFrameArgs::Create(now,
- now - BeginFrameArgs::DefaultInterval(),
- BeginFrameArgs::DefaultInterval());
+ return BeginFrameArgs::Create(
+ location, now, now - BeginFrameArgs::DefaultInterval(),
+ BeginFrameArgs::DefaultInterval(), BeginFrameArgs::NORMAL);
}
bool operator==(const BeginFrameArgs& lhs, const BeginFrameArgs& rhs) {
- return (lhs.frame_time == rhs.frame_time) && (lhs.deadline == rhs.deadline) &&
- (lhs.interval == rhs.interval);
+ return (lhs.type == rhs.type) && (lhs.frame_time == rhs.frame_time) &&
+ (lhs.deadline == rhs.deadline) && (lhs.interval == rhs.interval);
}
::std::ostream& operator<<(::std::ostream& os, const BeginFrameArgs& args) {
@@ -75,7 +84,8 @@ bool operator==(const BeginFrameArgs& lhs, const BeginFrameArgs& rhs) {
}
void PrintTo(const BeginFrameArgs& args, ::std::ostream* os) {
- *os << "BeginFrameArgs(" << args.frame_time.ToInternalValue() << ", "
+ *os << "BeginFrameArgs(" << BeginFrameArgs::TypeToString(args.type) << ", "
+ << args.frame_time.ToInternalValue() << ", "
<< args.deadline.ToInternalValue() << ", "
<< args.interval.InMicroseconds() << "us)";
}

Powered by Google App Engine
This is Rietveld 408576698