Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 735683002: SearchEngineTabHelper: added delegate_ member initializer to constructor. (Closed)

Created:
6 years, 1 month ago by Lukasz Jagielski
Modified:
6 years, 1 month ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

SearchEngineTabHelper: added delegate_ member initializer to constructor. BUG=none Committed: https://crrev.com/a45e34acb629d58dcc3e8f9a61b2974934d4fb31 Cr-Commit-Position: refs/heads/master@{#304789}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/search_engines/search_engine_tab_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Lukasz Jagielski
Hi, PTAL at my CL proposition. Regards, Łukasz
6 years, 1 month ago (2014-11-18 11:37:20 UTC) #2
Peter Kasting
LGTM; is there a bug this was causing? Is so add it to the BUG= ...
6 years, 1 month ago (2014-11-18 20:38:24 UTC) #3
Lukasz Jagielski
On 2014/11/18 20:38:24, Peter Kasting wrote: > LGTM; is there a bug this was causing? ...
6 years, 1 month ago (2014-11-19 08:13:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/735683002/1
6 years, 1 month ago (2014-11-19 08:13:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-19 09:05:21 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a45e34acb629d58dcc3e8f9a61b2974934d4fb31 Cr-Commit-Position: refs/heads/master@{#304789}
6 years, 1 month ago (2014-11-19 09:05:58 UTC) #8
Peter Kasting
6 years, 1 month ago (2014-11-19 09:13:26 UTC) #9
Message was sent while issue was closed.
On 2014/11/19 08:13:40, Lukasz Jagielski wrote:
> On 2014/11/18 20:38:24, Peter Kasting wrote:
> > LGTM; is there a bug this was causing?  Is so add it to the BUG= line,
> otherwise
> > write "BUG=none".
> 
> Well I just saw use of uninitialized value in memcheck. Should I report a bug
> for this in the future?

No, no need, but do add something to the CL description in the future in such
cases about how the fix came about (e.g. "saw this uninitialized value in
memcheck").

Powered by Google App Engine
This is Rietveld 408576698