Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 735653003: Revert "Use a stub in crankshaft for grow store arrays." (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/hydrogen.cc ('k') | src/ia32/interface-descriptors-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/base/bits.h" 7 #include "src/base/bits.h"
8 #include "src/double.h" 8 #include "src/double.h"
9 #include "src/factory.h" 9 #include "src/factory.h"
10 #include "src/hydrogen-infer-representation.h" 10 #include "src/hydrogen-infer-representation.h"
(...skipping 765 matching lines...) Expand 10 before | Expand all | Expand 10 after
776 if (use.value()->IsInstruction()) { 776 if (use.value()->IsInstruction()) {
777 DCHECK(HInstruction::cast(use.value())->IsLinked()); 777 DCHECK(HInstruction::cast(use.value())->IsLinked());
778 } 778 }
779 } 779 }
780 } 780 }
781 #endif 781 #endif
782 782
783 783
784 bool HInstruction::CanDeoptimize() { 784 bool HInstruction::CanDeoptimize() {
785 // TODO(titzer): make this a virtual method? 785 // TODO(titzer): make this a virtual method?
786 // TODO(all): Some of these may be incorrect, since any method that can
787 // collect can provoke lazy deoptimization. Methods like CallNew can
788 // certainly do that.
789 switch (opcode()) { 786 switch (opcode()) {
790 case HValue::kAbnormalExit: 787 case HValue::kAbnormalExit:
791 case HValue::kAccessArgumentsAt: 788 case HValue::kAccessArgumentsAt:
792 case HValue::kAllocate: 789 case HValue::kAllocate:
793 case HValue::kArgumentsElements: 790 case HValue::kArgumentsElements:
794 case HValue::kArgumentsLength: 791 case HValue::kArgumentsLength:
795 case HValue::kArgumentsObject: 792 case HValue::kArgumentsObject:
796 case HValue::kBlockEntry: 793 case HValue::kBlockEntry:
797 case HValue::kBoundsCheckBaseIndexInformation: 794 case HValue::kBoundsCheckBaseIndexInformation:
798 case HValue::kCallFunction: 795 case HValue::kCallFunction:
799 case HValue::kCallNew: 796 case HValue::kCallNew:
800 case HValue::kCallNewArray: 797 case HValue::kCallNewArray:
801 case HValue::kCallStub: 798 case HValue::kCallStub:
799 case HValue::kCallWithDescriptor:
802 case HValue::kCapturedObject: 800 case HValue::kCapturedObject:
803 case HValue::kClassOfTestAndBranch: 801 case HValue::kClassOfTestAndBranch:
804 case HValue::kCompareGeneric: 802 case HValue::kCompareGeneric:
805 case HValue::kCompareHoleAndBranch: 803 case HValue::kCompareHoleAndBranch:
806 case HValue::kCompareMap: 804 case HValue::kCompareMap:
807 case HValue::kCompareMinusZeroAndBranch: 805 case HValue::kCompareMinusZeroAndBranch:
808 case HValue::kCompareNumericAndBranch: 806 case HValue::kCompareNumericAndBranch:
809 case HValue::kCompareObjectEqAndBranch: 807 case HValue::kCompareObjectEqAndBranch:
810 case HValue::kConstant: 808 case HValue::kConstant:
811 case HValue::kConstructDouble: 809 case HValue::kConstructDouble:
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
858 return false; 856 return false;
859 857
860 case HValue::kAdd: 858 case HValue::kAdd:
861 case HValue::kAllocateBlockContext: 859 case HValue::kAllocateBlockContext:
862 case HValue::kApplyArguments: 860 case HValue::kApplyArguments:
863 case HValue::kBitwise: 861 case HValue::kBitwise:
864 case HValue::kBoundsCheck: 862 case HValue::kBoundsCheck:
865 case HValue::kBranch: 863 case HValue::kBranch:
866 case HValue::kCallJSFunction: 864 case HValue::kCallJSFunction:
867 case HValue::kCallRuntime: 865 case HValue::kCallRuntime:
868 case HValue::kCallWithDescriptor:
869 case HValue::kChange: 866 case HValue::kChange:
870 case HValue::kCheckHeapObject: 867 case HValue::kCheckHeapObject:
871 case HValue::kCheckInstanceType: 868 case HValue::kCheckInstanceType:
872 case HValue::kCheckMapValue: 869 case HValue::kCheckMapValue:
873 case HValue::kCheckMaps: 870 case HValue::kCheckMaps:
874 case HValue::kCheckSmi: 871 case HValue::kCheckSmi:
875 case HValue::kCheckValue: 872 case HValue::kCheckValue:
876 case HValue::kClampToUint8: 873 case HValue::kClampToUint8:
877 case HValue::kDateField: 874 case HValue::kDateField:
878 case HValue::kDeoptimize: 875 case HValue::kDeoptimize:
(...skipping 3924 matching lines...) Expand 10 before | Expand all | Expand 10 after
4803 break; 4800 break;
4804 case HObjectAccess::kExternalMemory: 4801 case HObjectAccess::kExternalMemory:
4805 os << "[external-memory]"; 4802 os << "[external-memory]";
4806 break; 4803 break;
4807 } 4804 }
4808 4805
4809 return os << "@" << access.offset(); 4806 return os << "@" << access.offset();
4810 } 4807 }
4811 4808
4812 } } // namespace v8::internal 4809 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/hydrogen.cc ('k') | src/ia32/interface-descriptors-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698