Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 73563004: Fix bogus allocation limit in allocation folding. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/mjsunit/allocation-folding.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3386 matching lines...) Expand 10 before | Expand all | Expand 10 after
3397 if (MustAllocateDoubleAligned()) { 3397 if (MustAllocateDoubleAligned()) {
3398 if (!dominator_allocate->MustAllocateDoubleAligned()) { 3398 if (!dominator_allocate->MustAllocateDoubleAligned()) {
3399 dominator_allocate->MakeDoubleAligned(); 3399 dominator_allocate->MakeDoubleAligned();
3400 } 3400 }
3401 if ((dominator_size_constant & kDoubleAlignmentMask) != 0) { 3401 if ((dominator_size_constant & kDoubleAlignmentMask) != 0) {
3402 dominator_size_constant += kDoubleSize / 2; 3402 dominator_size_constant += kDoubleSize / 2;
3403 new_dominator_size += kDoubleSize / 2; 3403 new_dominator_size += kDoubleSize / 2;
3404 } 3404 }
3405 } 3405 }
3406 3406
3407 if (new_dominator_size > Page::kMaxNonCodeHeapObjectSize) { 3407 if (new_dominator_size > isolate()->heap()->MaxRegularSpaceAllocationSize()) {
3408 if (FLAG_trace_allocation_folding) { 3408 if (FLAG_trace_allocation_folding) {
3409 PrintF("#%d (%s) cannot fold into #%d (%s) due to size: %d\n", 3409 PrintF("#%d (%s) cannot fold into #%d (%s) due to size: %d\n",
3410 id(), Mnemonic(), dominator_allocate->id(), 3410 id(), Mnemonic(), dominator_allocate->id(),
3411 dominator_allocate->Mnemonic(), new_dominator_size); 3411 dominator_allocate->Mnemonic(), new_dominator_size);
3412 } 3412 }
3413 return; 3413 return;
3414 } 3414 }
3415 3415
3416 HInstruction* new_dominator_size_constant = HConstant::CreateAndInsertBefore( 3416 HInstruction* new_dominator_size_constant = HConstant::CreateAndInsertBefore(
3417 zone, 3417 zone,
(...skipping 933 matching lines...) Expand 10 before | Expand all | Expand 10 after
4351 break; 4351 break;
4352 case kExternalMemory: 4352 case kExternalMemory:
4353 stream->Add("[external-memory]"); 4353 stream->Add("[external-memory]");
4354 break; 4354 break;
4355 } 4355 }
4356 4356
4357 stream->Add("@%d", offset()); 4357 stream->Add("@%d", offset());
4358 } 4358 }
4359 4359
4360 } } // namespace v8::internal 4360 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/allocation-folding.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698