Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Unified Diff: src/array.js

Issue 7356013: Implement Object.prototype.hasOwnProperty in generated code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/code-stubs.h » ('j') | src/hydrogen.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/array.js
diff --git a/src/array.js b/src/array.js
index 60cf3f0c5270e6fca1f7856a73547add6bbab35c..c81ddd346a8a85b0acf0fc03e35fba80dc737849 100644
--- a/src/array.js
+++ b/src/array.js
@@ -233,7 +233,7 @@ function SmartSlice(array, start_i, del_count, len, deleted_elements) {
}
for (; j < interval_limit; j++) {
// ECMA-262 15.4.4.12 line 10. The spec could also be
- // interpreted such that %HasLocalProperty would be the
+ // interpreted such that %HasOwnProperty would be the
// appropriate test. We follow KJS in consulting the
// prototype.
var current = array[j];
@@ -245,7 +245,7 @@ function SmartSlice(array, start_i, del_count, len, deleted_elements) {
if (!IS_UNDEFINED(key)) {
if (key >= start_i) {
// ECMA-262 15.4.4.12 line 10. The spec could also be
- // interpreted such that %HasLocalProperty would be the
+ // interpreted such that %HasOwnProperty would be the
// appropriate test. We follow KJS in consulting the
// prototype.
var current = array[key];
@@ -273,7 +273,7 @@ function SmartMove(array, start_i, del_count, len, num_additional_args) {
var interval_limit = j + intervals[++k];
while (j < start_i && j < interval_limit) {
// The spec could also be interpreted such that
- // %HasLocalProperty would be the appropriate test. We follow
+ // %HasOwnProperty would be the appropriate test. We follow
// KJS in consulting the prototype.
var current = array[j];
if (!IS_UNDEFINED(current) || j in array) {
@@ -284,7 +284,7 @@ function SmartMove(array, start_i, del_count, len, num_additional_args) {
j = start_i + del_count;
while (j < interval_limit) {
// ECMA-262 15.4.4.12 lines 24 and 41. The spec could also be
- // interpreted such that %HasLocalProperty would be the
+ // interpreted such that %HasOwnProperty would be the
// appropriate test. We follow KJS in consulting the
// prototype.
var current = array[j];
@@ -297,7 +297,7 @@ function SmartMove(array, start_i, del_count, len, num_additional_args) {
if (!IS_UNDEFINED(key)) {
if (key < start_i) {
// The spec could also be interpreted such that
- // %HasLocalProperty would be the appropriate test. We follow
+ // %HasOwnProperty would be the appropriate test. We follow
// KJS in consulting the prototype.
var current = array[key];
if (!IS_UNDEFINED(current) || key in array) {
@@ -305,7 +305,7 @@ function SmartMove(array, start_i, del_count, len, num_additional_args) {
}
} else if (key >= start_i + del_count) {
// ECMA-262 15.4.4.12 lines 24 and 41. The spec could also
- // be interpreted such that %HasLocalProperty would be the
+ // be interpreted such that %HasOwnProperty would be the
// appropriate test. We follow KJS in consulting the
// prototype.
var current = array[key];
@@ -327,7 +327,7 @@ function SmartMove(array, start_i, del_count, len, num_additional_args) {
function SimpleSlice(array, start_i, del_count, len, deleted_elements) {
for (var i = 0; i < del_count; i++) {
var index = start_i + i;
- // The spec could also be interpreted such that %HasLocalProperty
+ // The spec could also be interpreted such that %HasOwnProperty
// would be the appropriate test. We follow KJS in consulting the
// prototype.
var current = array[index];
@@ -346,7 +346,7 @@ function SimpleMove(array, start_i, del_count, len, num_additional_args) {
var from_index = i + del_count - 1;
var to_index = i + num_additional_args - 1;
// The spec could also be interpreted such that
- // %HasLocalProperty would be the appropriate test. We follow
+ // %HasOwnProperty would be the appropriate test. We follow
// KJS in consulting the prototype.
var current = array[from_index];
if (!IS_UNDEFINED(current) || from_index in array) {
@@ -360,7 +360,7 @@ function SimpleMove(array, start_i, del_count, len, num_additional_args) {
var from_index = i + del_count;
var to_index = i + num_additional_args;
// The spec could also be interpreted such that
- // %HasLocalProperty would be the appropriate test. We follow
+ // %HasOwnProperty would be the appropriate test. We follow
// KJS in consulting the prototype.
var current = array[from_index];
if (!IS_UNDEFINED(current) || from_index in array) {
« no previous file with comments | « no previous file | src/code-stubs.h » ('j') | src/hydrogen.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698