Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 7356005: Chang Heap::FreeQueuedChunks to prepare queued large chunks for StoreBuffer::Filter. (Closed)

Created:
9 years, 5 months ago by Vyacheslav Egorov (Chromium)
Modified:
9 years, 5 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Chang Heap::FreeQueuedChunks to prepare queued large chunks for StoreBuffer::Filter. We split large chunks into separate smaller kPageSize aligned pieces to ensure that MemoryChunk::FromAnyPointerAddress would be able to find chunk containing slot even if the chunk was unlinked from the list of large chunks. R=lrn@chromium.org BUG=v8:1554 Committed: http://code.google.com/p/v8/source/detail?r=8621

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M src/heap.cc View 1 chunk +22 lines, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
9 years, 5 months ago (2011-07-13 00:29:03 UTC) #1
Lasse Reichstein
9 years, 5 months ago (2011-07-13 07:07:13 UTC) #2
LGTM, if you can make the comment.

http://codereview.chromium.org/7356005/diff/1/src/heap.cc
File src/heap.cc (right):

http://codereview.chromium.org/7356005/diff/1/src/heap.cc#newcode5993
src/heap.cc:5993: while (inner <= inner_last) {
It's not obvious why this can't crash, if the end of the large object chunk is
just a few bytes into the inner_last chunk.
Make a comment saying why it won't crash.

Powered by Google App Engine
This is Rietveld 408576698