Range feedback for binary integer operations.

runtime/vm/assembler_ia32_test.cc

Index: runtime/vm/assembler_ia32_test.cc
diff --git a/runtime/vm/assembler_ia32_test.cc b/runtime/vm/assembler_ia32_test.cc
index bd5a0fc62db58d6e8828bb9ad119146481780844..07e7723763d7c2eecaafc193cfa5d6ba9caea8f9 100644
--- a/runtime/vm/assembler_ia32_test.cc
+++ b/runtime/vm/assembler_ia32_test.cc
@@ -398,14 +398,20 @@ ASSEMBLER_TEST_GENERATE(Bitwise, assembler) {
   __ pushl(Immediate(0x1C));
   __ xorl(ECX, Address(ESP, 0));  // 0x65B.
   __ popl(EAX);  // Discard.
+  __ movl(EAX, Address(ESP, kWordSize));
+  __ movl(EDX, Immediate(0xB0));
+  __ orl(Address(EAX, 0), EDX);
   __ movl(EAX, ECX);
   __ ret();
 }
 
 
 ASSEMBLER_TEST_RUN(Bitwise, test) {
-  typedef int (*Bitwise)();
-  EXPECT_EQ(0x65B, reinterpret_cast<Bitwise>(test->entry())());
+  typedef int (*Bitwise)(int* value);
+  int value = 0xA;
+  const int result = reinterpret_cast<Bitwise>(test->entry())(&value);
+  EXPECT_EQ(0x65B, result);
+  EXPECT_EQ(0xBA, value);
 }
 
 
@@ -3399,6 +3405,57 @@ ASSEMBLER_TEST_RUN(BitTest, test) {
 }
 
 
+ASSEMBLER_TEST_GENERATE(ComputeRange, assembler) {
+  Label miss, done;
+  __ movl(ECX, Address(ESP, 1 * kWordSize));
+
+  __ pushl(ESI);
+  __ pushl(EDI);
+  __ ComputeRange(EAX, ECX, ESI, EDI, &miss);
+  __ jmp(&done);
+
+  __ Bind(&miss);
+  __ movl(EAX, Immediate(-1));
+
+  __ Bind(&done);
+  __ popl(EDI);
+  __ popl(ESI);
+  __ ret();
+}
+
+
+ASSEMBLER_TEST_RUN(ComputeRange, test) {
+  typedef intptr_t (*ComputeRange)(RawObject* value);
+  ComputeRange range_of = reinterpret_cast<ComputeRange>(test->entry());
+
+  EXPECT_EQ(0, range_of(Smi::New(0)));
+  EXPECT_EQ(0, range_of(Smi::New(1)));
+  EXPECT_EQ(ICData::kSignBit, range_of(Smi::New(-1)));
+  EXPECT_EQ(0, range_of(Smi::New(Smi::kMaxValue)));
+  EXPECT_EQ(ICData::kSignBit, range_of(Smi::New(Smi::kMinValue)));
+
+  EXPECT_EQ(ICData::kInt32Bit, range_of(Integer::New(Smi::kMaxValue + 1)));
+  EXPECT_EQ(ICData::kInt32Bit | ICData::kSignBit,
+            range_of(Integer::New(Smi::kMinValue - 1)));
+  EXPECT_EQ(ICData::kInt32Bit, range_of(Integer::New(kMaxInt32)));
+  EXPECT_EQ(ICData::kInt32Bit | ICData::kSignBit,
+            range_of(Integer::New(kMinInt32)));
+
+  EXPECT_EQ(ICData::kUint32Bit,
+            range_of(Integer::New(static_cast<int64_t>(kMaxInt32) + 1)));
+  EXPECT_EQ(ICData::kUint32Bit, range_of(Integer::New(kMaxUint32)));
+
+  EXPECT_EQ(ICData::kInt64Bit,
+            range_of(Integer::New(static_cast<int64_t>(kMaxUint32) + 1)));
+  EXPECT_EQ(ICData::kInt64Bit,
+            range_of(Integer::New(static_cast<int64_t>(kMinInt32) - 1)));
+  EXPECT_EQ(ICData::kInt64Bit, range_of(Integer::New(kMaxInt64)));
+  EXPECT_EQ(ICData::kInt64Bit, range_of(Integer::New(kMinInt64)));
+
+  EXPECT_EQ(-1, range_of(Bool::True().raw()));
+}
+
+
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32