Range feedback for binary integer operations.

runtime/vm/assembler_arm64_test.cc

Index: runtime/vm/assembler_arm64_test.cc
diff --git a/runtime/vm/assembler_arm64_test.cc b/runtime/vm/assembler_arm64_test.cc
index bb6bd0acff3a58739dfb356f661befca8811a6ce..ce1e994adbaae7162c3dc04f92e0ec0d2b564c5f 100644
--- a/runtime/vm/assembler_arm64_test.cc
+++ b/runtime/vm/assembler_arm64_test.cc
@@ -3523,6 +3523,69 @@ ASSEMBLER_TEST_GENERATE(StoreIntoObject, assembler) {
   __ ret();
 }
 
+
+ASSEMBLER_TEST_GENERATE(ComputeRange, assembler) {
+  __ SetupDartSP(kTestStackSpace);
+  __ TagAndPushPP();
+  __ LoadPoolPointer(PP);
+  __ Push(LR);

[zra, 2014/12/15 16:01:40]

If there's no call, I don't think you need to push LR.

[Vyacheslav Egorov (Google), 2014/12/15 17:20:05]

Done.

+  Label miss, done;
+  __ mov(R1, R0);
+  __ ComputeRange(R0, R1, R2, &miss);
+  __ b(&done);
+
+  __ Bind(&miss);
+  __ LoadImmediate(R0, -1, kNoPP);
+
+  __ Bind(&done);
+  __ Pop(LR);
+  __ PopAndUntagPP();
+  __ mov(CSP, SP);
+  __ ret();
+}
+
+
+ASSEMBLER_TEST_RUN(ComputeRange, test) {
+  typedef intptr_t (*ComputeRange)(intptr_t value) DART_UNUSED;
+
+#define RANGE_OF(v)                                              \
+  (EXECUTE_TEST_CODE_INTPTR_INTPTR(                              \
+    ComputeRange, test->entry(), reinterpret_cast<intptr_t>(v)))
+
+  EXPECT_EQ(ICData::kInt32Bit, RANGE_OF(Smi::New(0)));
+  EXPECT_EQ(ICData::kInt32Bit, RANGE_OF(Smi::New(1)));
+  EXPECT_EQ(ICData::kInt32Bit, RANGE_OF(Smi::New(kMaxInt32)));
+  EXPECT_EQ(ICData::kInt32Bit | ICData::kSignBit,
+            RANGE_OF(Smi::New(-1)));
+  EXPECT_EQ(ICData::kInt32Bit | ICData::kSignBit,
+            RANGE_OF(Smi::New(kMinInt32)));
+
+  EXPECT_EQ(ICData::kUint32Bit,
+            RANGE_OF(Smi::New(static_cast<int64_t>(kMaxInt32) + 1)));
+  EXPECT_EQ(ICData::kUint32Bit,
+            RANGE_OF(Smi::New(kMaxUint32)));
+
+  // On 64-bit platforms we don't track the sign of the smis outside of
+  // int32 range because it is not needed to distinguish kInt32Range from
+  // kUint32Range.
+  EXPECT_EQ(ICData::kSignBit,
+            RANGE_OF(Smi::New(static_cast<int64_t>(kMinInt32) - 1)));
+  EXPECT_EQ(ICData::kSignBit,
+            RANGE_OF(Smi::New(static_cast<int64_t>(kMaxUint32) + 1)));
+  EXPECT_EQ(ICData::kSignBit, RANGE_OF(Smi::New(Smi::kMaxValue)));
+  EXPECT_EQ(ICData::kSignBit, RANGE_OF(Smi::New(Smi::kMinValue)));
+
+  EXPECT_EQ(ICData::kInt64Bit, RANGE_OF(Integer::New(Smi::kMaxValue + 1)));
+  EXPECT_EQ(ICData::kInt64Bit, RANGE_OF(Integer::New(Smi::kMinValue - 1)));
+  EXPECT_EQ(ICData::kInt64Bit, RANGE_OF(Integer::New(kMaxInt64)));
+  EXPECT_EQ(ICData::kInt64Bit, RANGE_OF(Integer::New(kMinInt64)));
+
+  EXPECT_EQ(-1, RANGE_OF(Bool::True().raw()));
+
+#undef RANGE_OF
+}
+
+
 }  // namespace dart
 
 #endif  // defined(TARGET_ARCH_ARM64)