Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Unified Diff: runtime/vm/assembler_ia32_test.cc

Issue 735543003: Range feedback for binary integer operations. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: ready for review Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/assembler_ia32_test.cc
diff --git a/runtime/vm/assembler_ia32_test.cc b/runtime/vm/assembler_ia32_test.cc
index bd5a0fc62db58d6e8828bb9ad119146481780844..81dacc20b00232107eb29d3e51a09a45fbde3b6f 100644
--- a/runtime/vm/assembler_ia32_test.cc
+++ b/runtime/vm/assembler_ia32_test.cc
@@ -3399,6 +3399,57 @@ ASSEMBLER_TEST_RUN(BitTest, test) {
}
+ASSEMBLER_TEST_GENERATE(ComputeRange, assembler) {
+ Label miss, done;
+ __ movl(ECX, Address(ESP, 1 * kWordSize));
+
+ __ pushl(ESI);
+ __ pushl(EDI);
+ __ ComputeRange(EAX, ECX, ESI, EDI, &miss);
+ __ jmp(&done);
+
+ __ Bind(&miss);
+ __ movl(EAX, Immediate(-1));
+
+ __ Bind(&done);
+ __ popl(EDI);
+ __ popl(ESI);
+ __ ret();
+}
+
+
+ASSEMBLER_TEST_RUN(ComputeRange, test) {
+ typedef intptr_t (*ComputeRange)(RawObject* value);
+ ComputeRange range_of = reinterpret_cast<ComputeRange>(test->entry());
+
+ EXPECT_EQ(0, range_of(Smi::New(0)));
+ EXPECT_EQ(0, range_of(Smi::New(1)));
+ EXPECT_EQ(ICData::kSignBit, range_of(Smi::New(-1)));
+ EXPECT_EQ(0, range_of(Smi::New(Smi::kMaxValue)));
+ EXPECT_EQ(ICData::kSignBit, range_of(Smi::New(Smi::kMinValue)));
+
+ EXPECT_EQ(ICData::kInt32Bit, range_of(Integer::New(Smi::kMaxValue + 1)));
+ EXPECT_EQ(ICData::kInt32Bit | ICData::kSignBit,
+ range_of(Integer::New(Smi::kMinValue - 1)));
+ EXPECT_EQ(ICData::kInt32Bit, range_of(Integer::New(kMaxInt32)));
+ EXPECT_EQ(ICData::kInt32Bit | ICData::kSignBit,
+ range_of(Integer::New(kMinInt32)));
+
+ EXPECT_EQ(ICData::kUint32Bit,
+ range_of(Integer::New(static_cast<int64_t>(kMaxInt32) + 1)));
+ EXPECT_EQ(ICData::kUint32Bit, range_of(Integer::New(kMaxUint32)));
+
+ EXPECT_EQ(ICData::kInt64Bit,
+ range_of(Integer::New(static_cast<int64_t>(kMaxUint32) + 1)));
+ EXPECT_EQ(ICData::kInt64Bit,
+ range_of(Integer::New(static_cast<int64_t>(kMinInt32) - 1)));
+ EXPECT_EQ(ICData::kInt64Bit, range_of(Integer::New(kMaxInt64)));
+ EXPECT_EQ(ICData::kInt64Bit, range_of(Integer::New(kMinInt64)));
+
+ EXPECT_EQ(-1, range_of(Bool::True().raw()));
+}
+
+
} // namespace dart
#endif // defined TARGET_ARCH_IA32

Powered by Google App Engine
This is Rietveld 408576698