Range feedback for binary integer operations.

runtime/vm/object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_OBJECT_H_
 #define VM_OBJECT_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/utils.h"
@@ skipping 3529 matching lines @@
   RawArray* arguments_descriptor() const {
     return raw_ptr()->args_descriptor_;
   }
 
   intptr_t NumArgsTested() const;
 
   intptr_t deopt_id() const {
     return raw_ptr()->deopt_id_;
   }
 
+  uint32_t range_feedback() const {
+    return raw_ptr()->range_feedback_;
+  }
+
   #define DEOPT_REASONS(V)                                                     \
     V(Unknown)                                                                 \
     V(InstanceGetter)                                                          \
     V(PolymorphicInstanceCallTestFail)                                         \
     V(InstanceCallNoICData)                                                    \
     V(IntegerToDouble)                                                         \
     V(BinarySmiOp)                                                             \
     V(BinaryMintOp)                                                            \
     V(UnaryMintOp)                                                             \
     V(ShiftMintOp)                                                             \
@@ skipping 74 matching lines @@
   }
 
   static intptr_t ic_data_offset() {
     return OFFSET_OF(RawICData, ic_data_);
   }
 
   static intptr_t owner_offset() {
     return OFFSET_OF(RawICData, owner_);
   }
 
+  static intptr_t range_feedback_offset() {
+    return OFFSET_OF(RawICData, range_feedback_);
+  }
+
   // Used for unoptimized static calls when no class-ids are checked.
   void AddTarget(const Function& target) const;
 
   // Adding checks.
 
   // Adds one more class test to ICData. Length of 'classes' must be equal to
   // the number of arguments tested. Use only for num_args_tested > 1.
   void AddCheck(const GrowableArray<intptr_t>& class_ids,
                 const Function& target) const;
   // Adds sorted so that Smi is the first class-id. Use only for
@@ skipping 54 matching lines @@
 
   static intptr_t CountIndexFor(intptr_t num_args) {
     return (num_args + 1);
   }
 
   bool IsUsedAt(intptr_t i) const;
 
   void GetUsedCidsForTwoArgs(GrowableArray<intptr_t>* first,
                              GrowableArray<intptr_t>* second) const;
 
+  enum RangeFeedback {
+    kSmiRange, kInt32Range, kUint32Range, kInt64Range
+  };
+
+  enum {
+    kSignBit = 1 << 0,
+    kInt32Bit = 1 << 1,
+    kUint32Bit = 1 << 2,
+    kInt64Bit = 1 << 3,
+    kBitsPerRangeFeedback = 4,
+    kRangeFeedbackMask = (1 << kBitsPerRangeFeedback) - 1
+  };

[srdjan, 2014/12/15 16:39:01]

I think it would be more readable to say, e.g., kInt32RangeBit.

[Vyacheslav Egorov (Google), 2014/12/15 17:20:05]

Done.

+
+  static const char* RangeFeedbackToString(RangeFeedback feedback) {
+    switch (feedback) {
+      case kSmiRange:
+        return "smi";
+      case kInt32Range:
+        return "int32";
+      case kUint32Range:
+        return "uint32";
+      case kInt64Range:
+        return "int64";
+      default:
+        UNREACHABLE();
+        return "?";
+    }
+  }
+
+  bool HasRangeFeedback() const;
+  RangeFeedback DecodeRangeFeedbackAt(intptr_t idx) const;
+
  private:
   RawArray* ic_data() const {
     return raw_ptr()->ic_data_;
   }
 
   void set_owner(const Function& value) const;
   void set_target_name(const String& value) const;
   void set_arguments_descriptor(const Array& value) const;
   void set_deopt_id(intptr_t value) const;
   void SetNumArgsTested(intptr_t value) const;
   void set_ic_data(const Array& value) const;
   void set_state_bits(uint32_t bits) const;
+  void set_range_feedback(uint32_t feedback);
 
   enum {
     kNumArgsTestedPos = 0,
     kNumArgsTestedSize = 2,
     kDeoptReasonPos = kNumArgsTestedPos + kNumArgsTestedSize,
     kDeoptReasonSize = kDeoptNumReasons,
     kIssuedJSWarningBit = kDeoptReasonPos + kDeoptReasonSize,
   };
 
   class NumArgsTestedBits : public BitField<uint32_t,
@@ skipping 3852 matching lines @@
 
 
 RawObject* MegamorphicCache::GetTargetFunction(const Array& array,
                                                intptr_t index) {
   return array.At((index * kEntryLength) + kTargetFunctionIndex);
 }
 
 }  // namespace dart
 
 #endif  // VM_OBJECT_H_